Page MenuHomePhabricator

Rename toolhub.apps.crawler.models.RunUrl.tools related_name from "crawer_runs" to "crawler_runs"
Closed, ResolvedPublicBUG REPORT

Description

Their seems to be a spelling error in the tools field of RunUrl model, in the crawler app. the related name of the tools field says "crawer_runs" instead of "crawler_runs". This is safe for now because we have not tried accessing RunUrl model instances through the tools model instance (couldn't find any place in the codebase where we called "crawer_runs"), but can be a future source of confusion.

Ideally "crawer_runs" should be renamed to "crawler_runs" and a new migration made to reflect that.

Event Timeline

bd808 renamed this task from Rename "crawer_runs" To "crawler_runs" to Rename "toolhub.apps.crawler.models.RunUrl.tools related_name from "crawer_runs" to "crawler_runs".Dec 13 2021, 6:17 PM
bd808 renamed this task from Rename "toolhub.apps.crawler.models.RunUrl.tools related_name from "crawer_runs" to "crawler_runs" to Rename toolhub.apps.crawler.models.RunUrl.tools related_name from "crawer_runs" to "crawler_runs".
Slst2020 added a project: User-Slst2020.
Slst2020 moved this task from To Do to Doing on the User-Slst2020 board.

Change 747796 had a related patch set uploaded (by Slavina Stefanova; author: Slavina Stefanova):

[wikimedia/toolhub@main] bug: fix typo in RunUrl model

https://gerrit.wikimedia.org/r/747796

Slst2020 moved this task from Groomed/Ready to In Progress on the Toolhub board.
bd808 changed the task status from Open to Stalled.Dec 17 2021, 4:59 PM
bd808 moved this task from In Progress to Review on the Toolhub board.
bd808 subscribed.

Marking as stalled pending a solution for T290357: Maintenance environment needed for running one-off commands to actually deploy the schema change to production.

Change 747796 merged by jenkins-bot:

[wikimedia/toolhub@main] bug: fix typo in RunUrl model

https://gerrit.wikimedia.org/r/747796

Change 749220 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2021-12-20-122341-production

https://gerrit.wikimedia.org/r/749220

Change 749220 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Bump container version to 2021-12-23-121200-production

https://gerrit.wikimedia.org/r/749220

This has been deployed to production.