MediaWiki\Page\PageAssertionException: The given PageIdentity User:* does not represent a proper page
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.38.0-wmf.9
reqId: 3522dead-376d-4e53-b7c0-4ee6c2c88e3f
Find reqId in Logstash
Find normalized_message in Logstash

normalized_message

[{reqId}] {exception_url}   MediaWiki\Page\PageAssertionException: The given PageIdentity {pageIdentity} does not represent a proper page

exception.trace

from /srv/mediawiki/php-1.38.0-wmf.9/includes/page/WikiPageFactory.php(59)
#0 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(425): MediaWiki\Page\WikiPageFactory->newFromTitle(Title)
#1 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(318): MediaWiki->initializeArticle()
#2 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(925): MediaWiki->performRequest()
#3 /srv/mediawiki/php-1.38.0-wmf.9/includes/MediaWiki.php(559): MediaWiki->main()
#4 /srv/mediawiki/php-1.38.0-wmf.9/index.php(53): MediaWiki->run()
#5 /srv/mediawiki/php-1.38.0-wmf.9/index.php(46): wfIndexMain()
#6 /srv/mediawiki/w/index.php(3): require(string)
#7 {main}

Impact

Notes

The input is a fuzzing attempt -- a sql query
Creates a reproducible exception with a GET request

Details

Request URL: https://en.wikipedia.org/wiki/Special:MyPage/sandbox*{obvious fuzzing input}

	Subject	Repo	Branch	Lines +/-
	Handle bad redirect target for personally identifiable special pages	mediawiki/core	master	+35 -0

Customize query in gerrit

Event Timeline

thcipriani created this task.Dec 9 2021, 4:31 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2021, 4:31 PM

thcipriani moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Dec 9 2021, 4:31 PM

This is related to a long title (>255 chars), not the fuzzy attempt.

The code changed for 1.38-wmf.12 in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/702614 - and it works for me (shows badtitle with message title-invalid-too-long).

In T297407#7560548, @Umherirrender wrote:

The code changed for 1.38-wmf.12 in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/702614 - and it works for me (shows badtitle with message title-invalid-too-long).

It only fails with Special:MyPage. It works when the redirected page is refreshed. SpecialMypage.php is using Title::makeTitle with the long subpage and that produces an Title object with an invalid title. That fails to redirect to badtitle also with current master.

Change 745582 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Handle bad redirect target for personally identifiable special pages

https://gerrit.wikimedia.org/r/745582

gerritbot added a project: Patch-For-Review.Dec 9 2021, 7:13 PM

Umherirrender unsubscribed.Jan 2 2022, 8:42 PM

Umherirrender claimed this task.Apr 11 2022, 8:32 PM

Umherirrender triaged this task as Low priority.

brennen added a project: User-brennen.Apr 28 2022, 6:37 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Change 745582 merged by jenkins-bot:

[mediawiki/core@master] Handle bad redirect target for personally identifiable special pages

https://gerrit.wikimedia.org/r/745582

Umherirrender closed this task as Resolved.Dec 8 2022, 9:10 PM

Umherirrender removed a project: Patch-For-Review.

ReleaseTaggerBot added a project: MW-1.40-notes (1.40.0-wmf.14; 2022-12-12).Dec 8 2022, 10:01 PM

MediaWiki\Page\PageAssertionException: The given PageIdentity User:* does not represent a proper pageClosed, ResolvedPublicPRODUCTION ERRORActions