Maniphest T297421

Search results are not clickable
Closed, ResolvedPublic
Actions

Description

Per @Jdlrobson on T251974#7558113, clicking search results does nothing:

{

screen_recording_2021-12-08_at_4.11.58_pm.mov.gif (470×868 px, 281 KB)

}

This is a regression from the Vue 3 migration.

Details

	Subject	Repo	Branch	Lines +/-
	Update WVUI to 0.3.4	mediawiki/core	master	+33 -27
	TypeaheadSearch: Avoid use of .native event binding	wvui	master	+5 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Duplicate		• STH	T302350 <Core Technology> Upgrade MediaWiki to Vue 3
		In Progress		None	T289017 [EPIC] <Core Technology> Upgrade MediaWiki projects from Vue 2 to Vue 3
		Resolved		egardner	T289104 Remove compatibility code for Vue 2 and Vuex 3
		Resolved		Jdforrester-WMF	T270783 Migrate WikiLambda Vue code to Vue3
		Resolved		egardner	T251974 Prepare Vue 2 to Vue 3 migration
		Resolved	Release	hashar	T293954 1.38.0-wmf.13 deployment blockers
		Resolved		Edtadros	T297421 Search results are not clickable

Event Timeline

Catrope created this task.Dec 9 2021, 6:10 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2021, 6:10 PM

Catrope added a parent task: T293953: 1.38.0-wmf.12 deployment blockers.Dec 9 2021, 6:10 PM

Catrope edited parent tasks, added: T293954: 1.38.0-wmf.13 deployment blockers; removed: T293953: 1.38.0-wmf.12 deployment blockers.

Catrope mentioned this in T251974: Prepare Vue 2 to Vue 3 migration.

Change 745576 had a related patch set uploaded (by Catrope; author: Catrope):

[wvui@master] TypeaheadSearch: Avoid use of .native event binding

https://gerrit.wikimedia.org/r/745576

gerritbot added a project: Patch-For-Review.Dec 9 2021, 6:15 PM

Jdlrobson triaged this task as Unbreak Now! priority.Dec 9 2021, 6:23 PM

Jdlrobson moved this task from Needs Analysis to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Change 745576 merged by jenkins-bot:

[wvui@master] TypeaheadSearch: Avoid use of .native event binding

https://gerrit.wikimedia.org/r/745576

Catrope mentioned this in rWVUIa1e5f4d3df9e: TypeaheadSearch: Avoid use of .native event binding.Dec 9 2021, 7:54 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 9 2021, 8:10 PM

Change 745630 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update WVUI to 0.3.4

https://gerrit.wikimedia.org/r/745630

gerritbot added a project: Patch-For-Review.Dec 10 2021, 12:33 AM

Change 745630 merged by jenkins-bot:

[mediawiki/core@master] Update WVUI to 0.3.4

https://gerrit.wikimedia.org/r/745630

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 10 2021, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 10 2021, 1:10 AM

This looks fixed to me.

@Edtadros could you confirm?

1.38.0-wmf.13 has reached group0 wikis (for example https://www.mediawiki.org/ ). If the issue is indeed solved, please mark this task as such ;)

It works on https://test.wikipedia.org hence it is resolved and this task is no more blocking 1.38.0-wmf.13

hashar mentioned this in T293954: 1.38.0-wmf.13 deployment blockers.Dec 15 2021, 4:41 PM