Page MenuHomePhabricator
Create Task
Maniphest T297431

InvalidArgumentException: The revision does not belong to the given page.
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error
normalized_message
[{reqId}] {exception_url}   InvalidArgumentException: The revision does not belong to the given page.
exception.trace
from /srv/mediawiki/php-1.38.0-wmf.12/includes/page/ParserOutputAccess.php(339)
#0 /srv/mediawiki/php-1.38.0-wmf.12/includes/page/ParserOutputAccess.php(249): MediaWiki\Page\ParserOutputAccess->checkPreconditions(MediaWiki\Page\PageStoreRecord, MediaWiki\Revision\RevisionStoreRecord, integer)
#1 /srv/mediawiki/php-1.38.0-wmf.12/extensions/DiscussionTools/includes/Notifications/EventDispatcher.php(57): MediaWiki\Page\ParserOutputAccess->getParserOutput(MediaWiki\Page\PageStoreRecord, ParserOptions, MediaWiki\Revision\RevisionStoreRecord)
#2 /srv/mediawiki/php-1.38.0-wmf.12/extensions/DiscussionTools/includes/Notifications/EventDispatcher.php(111): MediaWiki\Extension\DiscussionTools\Notifications\EventDispatcher::getParsedRevision(MediaWiki\Revision\RevisionStoreRecord)
#3 /srv/mediawiki/php-1.38.0-wmf.12/extensions/DiscussionTools/includes/Hooks/EchoHooks.php(97): MediaWiki\Extension\DiscussionTools\Notifications\EventDispatcher::generateEventsForRevision(array, MediaWiki\Revision\RevisionStoreRecord)
#4 /srv/mediawiki/php-1.38.0-wmf.12/includes/HookContainer/HookContainer.php(338): MediaWiki\Extension\DiscussionTools\Hooks\EchoHooks::onEchoGetEventsForRevision(array, MediaWiki\Revision\RevisionStoreRecord, boolean)
#5 /srv/mediawiki/php-1.38.0-wmf.12/includes/HookContainer/HookContainer.php(137): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#6 /srv/mediawiki/php-1.38.0-wmf.12/includes/Hooks.php(137): MediaWiki\HookContainer\HookContainer->run(string, array, array)
#7 /srv/mediawiki/php-1.38.0-wmf.12/extensions/Echo/includes/DiscussionParser.php(165): Hooks::run(string, array)
#8 /srv/mediawiki/php-1.38.0-wmf.12/extensions/Echo/includes/EchoHooks.php(507): EchoDiscussionParser::generateEventsForRevision(MediaWiki\Revision\RevisionStoreRecord, boolean)
#9 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/MWCallableUpdate.php(38): EchoHooks::{closure}()
#10 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(507): MWCallableUpdate->doUpdate()
#11 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(392): DeferredUpdates::attemptUpdate(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#12 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(221): DeferredUpdates::run(MWCallableUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#13 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdatesScope.php(267): DeferredUpdates::{closure}(MWCallableUpdate, integer)
#14 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdatesScope.php(196): DeferredUpdatesScope->processStageQueue(integer, integer, Closure)
#15 /srv/mediawiki/php-1.38.0-wmf.12/includes/deferred/DeferredUpdates.php(242): DeferredUpdatesScope->processUpdates(integer, Closure)
#16 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(1106): DeferredUpdates::doUpdates()
#17 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(830): MediaWiki->restInPeace()
#18 /srv/mediawiki/php-1.38.0-wmf.12/includes/MediaWiki.php(579): MediaWiki->doPostOutputShutdown()
#19 /srv/mediawiki/php-1.38.0-wmf.12/index.php(53): MediaWiki->run()
#20 /srv/mediawiki/php-1.38.0-wmf.12/index.php(46): wfIndexMain()
#21 /srv/mediawiki/w/index.php(3): require(string)
#22 {main}
Notes

11 of these in the last hour. Unclear impact.

Details

Request URL
https://en.wikipedia.org/w/index.php?title=*&action=submit
SubjectRepoBranchLines +/-
Fix PageRecord lookupmediawiki/extensions/DiscussionToolswmf/1.38.0-wmf.12+2 -2
Fix PageRecord lookupmediawiki/extensions/DiscussionToolsmaster+2 -2
Customize query in gerrit

Related Objects

Event Timeline

dancy created this task.Dec 9 2021, 8:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 9 2021, 8:27 PM
brennen subscribed.Dec 9 2021, 9:03 PM

Now 30 of these since deploy of 1.38.0-wmf.12 (T293953) - logspam-watch output:

30      _▂▃▁▂▃▃ 2004    2053 ◦  InvalidArgument.....    .12 i/p/ParserOutputAccess:339  The revision does not belong to the given page.

Not sure if that's ticking upwards or not.

dancy added a parent task: T293953: 1.38.0-wmf.12 deployment blockers.Dec 9 2021, 9:49 PM
Umherirrender added a project: Notifications (Echo).Dec 9 2021, 11:04 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 9 2021, 11:04 PM
Umherirrender added a project: DiscussionTools.Dec 9 2021, 11:15 PM
matmarex subscribed.Dec 10 2021, 10:28 AM

We haven't changed this code recently. My first suspicion is another bug in MediaWiki core similar to T289717.

matmarex added a subscriber: daniel.Dec 10 2021, 10:33 AM

Maybe caused by rMWde63ad823abe: PageStore: avoid getPageById, since it bypasses caching.?

The code I added in rEDTO4bbbdc970330: EventDispatcher: Try really, really hard to read from master relied on the null being returned with the READ_NORMAL flag.

daniel claimed this task.Dec 10 2021, 11:52 AM
matmarex added a comment.Dec 10 2021, 12:08 PM

I've been trying to understand that code in the meantime, I feel like I understand less about it the more I read, but I found and fixed an unrelated bug: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/745804

daniel added a comment.Dec 10 2021, 12:18 PM
In T297431#7562475, @matmarex wrote:

The code I added in rEDTO4bbbdc970330: EventDispatcher: Try really, really hard to read from master relied on the null being returned with the READ_NORMAL flag.

The problem in that code is that it uses getPageByReference, which will do a lookup by namespace and title (PageReference doesn't have an ID). It only worked by accident, due to me trying too hard to optimize (which led to T296063).

The code in EventDispatcher should use getPageById() instead. I'll make a patch.

matmarex added a comment.Dec 10 2021, 12:24 PM

Thanks.

Can you explain why the lookup by namespace and title shouldn't work?

daniel added a comment.Dec 10 2021, 12:33 PM
In T297431#7562659, @matmarex wrote:

Thanks.

Can you explain why the lookup by namespace and title shouldn't work?

I don't have a complete mental model of how this error happens, but during page moves, the association between page ID and title gets out of whack. RevisionStore tries to re-use Title objects provided by the caller, so you may end up with a Title instance that has the correct ID bot the wrong title (or vice versa) still in memory.

To avoid this, we can force a read from master, which is what you are doing. But the canonical association between revision and title is by page ID, and a mismatch will trigger "The revision does not belong to the given page". So doing the lookup by page ID should fix it.

gerritbot added a comment.Dec 10 2021, 12:34 PM

Change 745829 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix PageRecord lookup

https://gerrit.wikimedia.org/r/745829

gerritbot added a project: Patch-For-Review.Dec 10 2021, 12:34 PM
gerritbot added a comment.Dec 10 2021, 12:53 PM

Change 745829 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix PageRecord lookup

https://gerrit.wikimedia.org/r/745829

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 10 2021, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 10 2021, 1:10 PM
gerritbot added a comment.Dec 10 2021, 1:41 PM

Change 745652 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.12] Fix PageRecord lookup

https://gerrit.wikimedia.org/r/745652

gerritbot added a project: Patch-For-Review.Dec 10 2021, 1:41 PM
Stashbot added a comment.Dec 10 2021, 4:43 PM

Mentioned in SAL (#wikimedia-operations) [2021-12-10T16:43:37Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/DiscussionTools/includes/Notifications/EventDispatcher.php: Backport: [[gerrit:745652|Fix PageRecord lookup (T297431)]] (duration: 00m 58s)

gerritbot added a comment.Dec 10 2021, 4:54 PM

Change 745652 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@wmf/1.38.0-wmf.12] Fix PageRecord lookup

https://gerrit.wikimedia.org/r/745652

Stashbot added a comment.Dec 10 2021, 4:56 PM

Mentioned in SAL (#wikimedia-operations) [2021-12-10T16:56:54Z] <dancy@deploy1002> Synchronized php-1.38.0-wmf.12/extensions/DiscussionTools/includes/Notifications/EventDispatcher.php: Backport: [[gerrit:745652|Fix PageRecord lookup (T297431)]] (duration: 00m 58s)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.13; 2021-12-13).Dec 10 2021, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 10 2021, 5:10 PM
Agusbou2015 subscribed.Dec 10 2021, 5:30 PM
matmarex added a project: Editing-team (Kanban Board).Dec 10 2021, 5:31 PM
matmarex moved this task from Incoming to Ready for Sign Off on the Editing-team (Kanban Board) board.
matmarex removed a parent task: T293953: 1.38.0-wmf.12 deployment blockers.
matmarex added a comment.Dec 10 2021, 5:35 PM

Should be resolved in production now.

Relevant Logstash search: https://logstash.wikimedia.org/goto/c97da891d7a21ae358728627c0c92ea5

image.png (523×2 px, 51 KB)

There were no errors in the last ~30 minutes since the fix was deployed.

matmarex edited projects, added MediaWiki-Core-Revision-backend; removed Notifications (Echo), Growth-Team, MediaWiki-Parser.Dec 10 2021, 5:37 PM
Umherirrender closed this task as Resolved.Dec 18 2021, 3:57 PM
Krinkle moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Jan 13 2022, 6:52 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits