Page MenuHomePhabricator
Create Task
Maniphest T297455

Blank Cargo Table Diagram
Closed, ResolvedPublicBUG REPORT
Actions

Description

MW 1.36.2 Cargo 3.0 (5decb5b) 2021-12-09T10:06:57

When I click on "Cargo Table Diagram" on Special Pages, on one of my wikis it opens the page but no diagram is displayed.
Many tables are defined and they show in the "Cargo Tables" special page. If I look at one of my other wikis, a table diagram is shown.

If do a Firefox Inspect on the diagram I can see that the <svg> tag has no content where it does on the other wiki, ie it just lists as <svg class="cargo-table-svg" width="1600"><g id="g-main"></g></svg>

I have a hunch that this might be related to some bad table definitions, but this is only because I had already done some other troubleshooting (see task T297456 )

I ran this with debugging enabled but didn't find anything helpful.

Details

SubjectRepoBranchLines +/-
Improve input validation for _parentTablesmediawiki/extensions/Cargomaster+40 -2
Customize query in gerrit

Related Objects

Event Timeline

Tenbergen created this task.Dec 10 2021, 5:09 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2021, 5:09 AM
Tenbergen updated the task description. (Show Details)Dec 10 2021, 5:10 AM
Tenbergen mentioned this in T297456: Bad "allows values" statement gets processed (at least somewhat).
Tenbergen updated the task description. (Show Details)Dec 10 2021, 5:15 AM

Here is what data-table-schemas actually contains, in case that helps:

{"AdmDuty":{"mFieldDescriptions":{"adminDoer":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"adminReceiver":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"dutyType":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"details":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"AwardReceivedBy":{"mFieldDescriptions":{"awardRecipient":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"awardSection":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"awardYear":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"DeptFileShare":{"mFieldDescriptions":{"FileSharePath":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"UsualDriveLetter":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Description":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"GrantInvestigator":{"mFieldDescriptions":{"Investigator":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"PI":{"mType":"Boolean","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"Grants":{"mFieldDescriptions":{"Agency":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Amount":{"mType":"Float","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"StartDate":{"mType":"Start date","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"EndDate":{"mType":"End date","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Fund":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Org":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Prog":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"AdditionalInfo":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"GrantAdmin":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"InfoSystems":{"mFieldDescriptions":{"description":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"processes":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"PathURL":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"MainContact":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Network":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"ControlledByACTM":{"mType":"Boolean","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"EducationRequirement":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"OnboardingTasks":{"mFieldDescriptions":{"timeframe":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"EducationRequirement":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"Person":{"mFieldDescriptions":{"FirstName":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"LastName":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Section":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":true,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"AppointmentType":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Address":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Email":{"mType":"Email","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Gender":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Rank":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"OrgChartID":{"mType":"Integer","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"SD":{"mType":"Date","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"ED":{"mType":"Date","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"PD":{"mType":"Date","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"RD":{"mType":"Date","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"PositionDescription":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"ReportsTo":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"SecretaryTo":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":true,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"GeneralIntro":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"BioSketch":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"ResearchInterest":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"ExternalRoles":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"ExternalAwards":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"PhoneDescriptionNumber":{"mFieldDescriptions":{"Description":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Number":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"Publication":{"mFieldDescriptions":{"title":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"authors":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"PI":{"mType":"Boolean","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"PublicationDate":{"mType":"Date","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Publisher":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"RoleHeldBy":{"mFieldDescriptions":{"holder":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"Roles":{"mFieldDescriptions":{"description":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"HiddenRole":{"mType":"Boolean","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Section":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"RoundsInstance":{"mFieldDescriptions":{"Presenter":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Title":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Description":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Series":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"StartTime":{"mType":"Start datetime","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"EndTime":{"mType":"End datetime","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Location":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Active":{"mType":"Boolean","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Section":{"mType":"Page (allowed values=a,b","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"RoundsSeries":{"mFieldDescriptions":{"AcademicContact":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"AdministrativeContact":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"UsualLocation":{"mType":"Wikitext","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"UsualTime":{"mType":"String","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"Section":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"MOCOMP":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"Sections":{"mFieldDescriptions":[]},"UserPerson":{"mFieldDescriptions":{"Person":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"UsesFileShare":{"mFieldDescriptions":{"FileShare":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"UsesInfoSystem":{"mFieldDescriptions":{"InfoSystem":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]},"AdditionalSetupInfo":{"mType":"Text","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}},"UsesOnboardingProcess":{"mFieldDescriptions":{"OnboardingProcess":{"mType":"Page","mSize":null,"mDependentOn":[],"mIsList":false,"mAllowedValues":null,"mIsMandatory":false,"mIsUnique":false,"mRegex":null,"mIsHidden":false,"mIsHierarchy":false,"mHierarchyStructure":null,"mOtherParams":[]}}}}
Yaron_Koren subscribed.Dec 10 2021, 9:52 PM

If you look in the browser console, do you see any JS errors?

Tenbergen added a comment.EditedDec 11 2021, 7:11 PM

I have this:

TypeError: node is undefined
    jQuery 4
        preProcessGraph
        preProcessGraph
        fn
        <anonymous>
    runScript https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:13
    loader https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:14
    flushCssBuffer https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:6
    addEmbeddedCSS https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:6
    execute https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:15
    doPropagation https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:7
    requestPropagation https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:8
    setAndPropagate https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:8
    implement https://wiki.umintmed.ca/load.php?lang=en&modules=startup&only=scripts&raw=1&skin=monobook:20
    <anonymous> jQuery

and in the "debugger" for index.php thre is

Error: Incorrect contents fetched, please reload.

I am starting to think this problem might be related to other problems elsewhere on the wiki. I run a maintenance script nightly that rebuilds a bunch of things. I thought it was running error free, but it might not be. I disabled some of the errors from showing because of the whole "deprecated" mess, and that might have masked a problem. I wonder if some data behind the scenes that is used to build this isn't being populated. Just a hunch for now, I am still digging.

Tenbergen added a comment.Dec 16 2021, 10:58 PM

I added some console.logs to ext.cargo.dagre.js and to dagre-d3.js,. There is a failure in dagre-d3.js because it chokes on a bad value it gets from one of my _parentTables entries, ie the wrong _localField= x

{{#cargo_declare:
_table = UsesFileShare
|FileShare= Page
|_parentTables= DeptFileShare(_localField=UsesFileShare, _remoteField=_pageName);
}}

instead of

{{#cargo_declare:
_table = UsesFileShare
|FileShare= Page
|_parentTables= DeptFileShare(_localField=FileShare, _remoteField=_pageName);
}}

I tried to give it a "_parentTables= foo" and it gave an error right on the wiki page "Error: Parent table "Array" doesn't exist." - that is not super clear either but at least it shows up right there. It accepts _parentTables= DeptFileShare(foo); but then it just shows the relationship as a _pageName to _pageName one. If I give it
_parentTables= DeptFileShare(_localField=foo, _remoteField=_pageName);
that causes the Cargo table diagram to go blank again.

So it seems this is a matter of better validating the _parentTables assignment.

gerritbot added a comment.Dec 20 2021, 11:30 PM

Change 748840 had a related patch set uploaded (by Tenbergen; author: Tenbergen):

[mediawiki/extensions/Cargo@master] Improve input validation for _parentTables

https://gerrit.wikimedia.org/r/748840

gerritbot added a project: Patch-For-Review.Dec 20 2021, 11:30 PM
gerritbot added a comment.Dec 22 2021, 12:29 AM

Change 748840 merged by jenkins-bot:

[mediawiki/extensions/Cargo@master] Improve input validation for _parentTables

https://gerrit.wikimedia.org/r/748840

Maintenance_bot removed a project: Patch-For-Review.Dec 22 2021, 1:10 AM
Yaron_Koren added a comment.Dec 22 2021, 3:19 PM

@Tenbergen - is this issue now fixed, on your wiki?

Aklapper added a comment.Jan 19 2022, 8:03 PM

@Tenbergen: Could you please answer the last comment? Thanks in advance!

Tenbergen added a comment.Jan 19 2022, 8:50 PM

It solved my problem, and will solve some other bad inputs, but haven't necessarily thought about all bad input possiblilities, and I don't know how to set up tests to validate.

Yaron_Koren closed this task as Resolved.Jan 19 2022, 9:32 PM
Yaron_Koren claimed this task.

Okay, great. I'm marking this bug as "Resolved", then, and if other validation issues come up, they can get their own tasks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL