Page MenuHomePhabricator

Structured tasks: reviewed and rejected articles should default to not watching the article
Closed, ResolvedPublic

Description

Currently we are automatically adding structured task articles users have reviewed to their watchlist, even when there is no edit made.

On the option of a watchlist being made possible in T289547, we should change the logic so that structured task articles for which no edit is made (i.e., add image task where the image is rejected, and add links task where at least one link is rejected and none accepted) do not get added to the watchlist for that user.

Event Timeline

@MMiller_WMF - moving back as I wanted to confirm that there is no measurement-related or other reason for us to be adding rejected article to someone's Watchlist?

Change 757540 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Structured tasks: Don't add the article to the user's watchlist when no edits are made

https://gerrit.wikimedia.org/r/757540

Urbanecm_WMF changed the task status from Open to In Progress.Jan 31 2022, 11:33 AM

Hi @RHo, I wanted to clarify the behavior for add link tasks. @Tgr brought up during code review whether this change should be specific to add image tasks. With T289547 (T289547#7551595), the watchlist option is shown when the user has made non-null edits to the article. For add link, we are showing the save dialog where the user made null edits as well (skip/rejected), but we are not showing the watchlist option.

Screen Shot 2022-02-01 at 10.21.37 AM.png (1×754 px, 119 KB)

Tgr changed the task status from In Progress to Open.Feb 2 2022, 6:20 AM
Tgr moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 757540 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Structured tasks: Don't add the article to the user's watchlist when no edits are made

https://gerrit.wikimedia.org/r/757540

Hi @RHo, I wanted to clarify the behavior for add link tasks. @Tgr brought up during code review whether this change should be specific to add image tasks. With T289547 (T289547#7551595), the watchlist option is shown when the user has made non-null edits to the article. For add link, we are showing the save dialog where the user made null edits as well (skip/rejected), but we are not showing the watchlist option.

Screen Shot 2022-02-01 at 10.21.37 AM.png (1×754 px, 119 KB)

Hi @mewoph - actually the intention is for this watchlist change to be for add link as well, that is why the task name on T289547 and tags was for "structured tasks" and in fact the watchlist option is shown on enbeta:

image.png (1×1 px, 313 KB)

Checked on testwiki wmf.21 - the default is not adding SE articles to a user's watchlist.

The following cases have been checked

  • Structured tasks - add link and add image
  • SE tasks

Also, two cases were checked when a user adds article to Watchlist outside of editing workflows
(1)

  • a user adds an article to a watchlist
  • then, a user sees the article in the Structured task feed
  • a user goes to the structured edit article and reject/skip suggestions - an article is still in user's Watchlist

(2)

  • a user gets to an article via Structured edits feed
  • a user, as a first action, adds the article to Watchlist
  • then, a user rejects/skips the suggestions - an article is still in user's Watchlist