Selecting a RadioOptionWidget programmatically scrolls it into view
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Dec 10 2021, 12:37 PM

Description

In general, changing form fields programmatically should not scroll them into view.

This was introduced in https://gerrit.wikimedia.org/r/c/oojs/ui/+/189989

Details

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.43.0	mediawiki/core	master	+824 -1 K
	Don't always scroll RadioOptionWidget when selected	oojs/ui	master	+0 -6

Customize query in gerrit

Event Timeline

Esanders created this task.Dec 10 2021, 12:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2021, 12:37 PM

Change 745839 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] Don't always scroll RadioOptionWidget when selected

https://gerrit.wikimedia.org/r/745839

gerritbot added a project: Patch-For-Review.Dec 10 2021, 1:41 PM

After this, the remaining OptionWidgets with scrollIntoViewOnSelect = true are MenuOptionWidget, OutlineOptionWidget & TabOptionWidget. As these typically exist inside their own scrollable container, I think it makes sense for these to always scroll into view.

Change 745839 merged by jenkins-bot:

[oojs/ui@master] Don't always scroll RadioOptionWidget when selected

https://gerrit.wikimedia.org/r/745839

Maintenance_bot removed a project: Patch-For-Review.Dec 10 2021, 8:10 PM

Change 753557 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] Update OOUI to v0.43.0

https://gerrit.wikimedia.org/r/753557

gerritbot added a project: Patch-For-Review.Jan 12 2022, 8:27 PM

Volker_E triaged this task as Medium priority.Jan 13 2022, 4:42 PM

Volker_E moved this task from Backlog to OOUI-0.43.0 on the OOUI board.

Volker_E edited projects, added OOUI (OOUI-0.43.0); removed OOUI.

Change 753557 merged by jenkins-bot: