[minor] CX - "oo-ui-labelElement-label" focused state displayed underlined
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Dec 10 2021, 11:25 PM

Description

When the issue was tested, the option Underline links on Special:Preferences-Appearance was set to "Never".

On CX page (tested on enwiki wmf.12) click on any suggestion
The Start translation dialog will be displayed and the focus will be on the "Start translation" button.

The label "Start translation" displays underline (the same case is for "Delete translation").

Screen Shot 2021-11-28 at 6.35.02 PM.png (574×1 px, 94 KB)

Screen Shot 2021-11-28 at 6.51.20 PM.png (644×962 px, 51 KB)

Note: as per @Pginer-WMF's comment

The underline in buttons is not expected. It is not part of the states for buttons in the Style guide.

Details

	Subject	Repo	Branch	Lines +/-
	Decrease specificity of link style overrides	mediawiki/extensions/ContentTranslation	master	+12 -12

Customize query in gerrit

Related Objects

Mentioned In: T291252: Regression in link styles on Content Translation

Event Timeline

Etonkovidova created this task.Dec 10 2021, 11:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 10 2021, 11:25 PM

Etonkovidova updated the task description. (Show Details)Dec 10 2021, 11:27 PM

Etonkovidova mentioned this in T291252: Regression in link styles on Content Translation.

Etonkovidova updated the task description. (Show Details)Dec 10 2021, 11:35 PM

If this only affects the dashboard, this bug may get fixed when replace the dashboad with the new one.

It happens in the editor too:

This regression was introduced in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/722130

Change 799374 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/ContentTranslation@master] Decrease specificity of link style overrides

https://gerrit.wikimedia.org/r/799374

gerritbot added a project: Patch-For-Review.May 25 2022, 4:56 PM

Change 799374 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Decrease specificity of link style overrides

https://gerrit.wikimedia.org/r/799374

ReleaseTaggerBot added a project: MW-1.39-notes (1.39.0-wmf.14; 2022-05-30).May 26 2022, 5:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 26 2022, 5:30 AM

• santhosh assigned this task to Esanders.May 26 2022, 6:35 AM

• santhosh added a project: Language-Team (Language-2022-April-June).

• santhosh moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2022-April-June) board.

The start translantion and delete translation are no longer underlined

{F35262096}

{F35262095}

EChukwukere-WMF moved this task from Recheck after deployment to Done on the Language-Team (Language-2022-April-June) board.Jun 22 2022, 2:52 AM

Pginer-WMF closed this task as Resolved.Jun 22 2022, 12:44 PM

	F34781260: Screen Shot 2021-11-28 at 6.35.02 PM.png
	Dec 10 2021, 11:25 PM

	F35176719: image.png
	May 25 2022, 4:27 PM

	F35176714: image.png
	May 25 2022, 4:27 PM

	F35176712: image.png
	May 25 2022, 4:27 PM

	F35176710: image.png
	May 25 2022, 4:27 PM

[minor] CX - "oo-ui-labelElement-label" focused state displayed underlined Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[minor] CX - "oo-ui-labelElement-label" focused state displayed underlined
Closed, ResolvedPublic
Actions