Page MenuHomePhabricator

Temporarily remove `{{SERVERNAME}}` from test survey question
Closed, ResolvedPublic

Assigned To
Authored By
jsn.sherman
Dec 11 2021, 3:21 AM
Referenced Files
F34882831: image.png
Dec 13 2021, 11:35 PM
F34882835: image.png
Dec 13 2021, 11:35 PM
F34882833: image.png
Dec 13 2021, 11:35 PM
F34882823: image.png
Dec 13 2021, 11:35 PM
F34882837: image.png
Dec 13 2021, 11:35 PM
F34882821: image.png
Dec 13 2021, 11:35 PM
F34882825: image.png
Dec 13 2021, 11:35 PM
F34882827: image.png
Dec 13 2021, 11:35 PM

Description

Since T297501 is unlikely to be merged in time for us to deploy the test survey, removing {{SERVERNAME}} from the survey question should resolve the issue temporarily for the test survey.

Event Timeline

Change 745969 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/WikimediaMessages@master] Remove `{{SITENAME}}` from test survey question

https://gerrit.wikimedia.org/r/745969

Change 745969 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Remove `{{SITENAME}}` from test survey question

https://gerrit.wikimedia.org/r/745969

Waiting on translatewiki to pickup the change so we can update the ca translation there.

jsn.sherman changed the task status from Open to In Progress.Dec 11 2021, 1:03 PM
jsn.sherman added a project: WikimediaMessages.

ca translation updated. Now we're waiting for translatewiki to commit back to WikimediaMessages.

jsn.sherman renamed this task from Temporarily remove `{{SITENAME}}` from test survey question to Temporarily remove `{{SERVERNAME}}` from test survey question.Dec 13 2021, 3:45 PM
jsn.sherman updated the task description. (Show Details)

@jsn.sherman,

I have verified the {{SERVERNAME}} has been removed from the Catalan Test Survey, and that the survey is displaying and functioning accurately at the following url: https://ca.wikipedia.beta.wmflabs.org/w/index.php?title=P%C3%A0gina_principal&quicksurvey=internal-gdi-safety-survey

NOTE: No testing was performed for the privacy statement link, since its currently pointing to a page that is not created... However when the Privacy Statement link ticket T295558 Link to the privacy statement https://phabricator.wikimedia.org/T295558 is implemented, then at that time I will execute testing for that link.

Compatibility Testing was performed on the following:
Desktop โ€“ Chrome version 96 Windows 10 / Microsoft Edge version 96 Windows 10 / Firefox version 95 Windows 10 / Opera version 82.0.4227.23 Windows 10 / Safari version 15 Mac OS Monterrey / Safari version 14 Mac OS Big Sur.
Mobile Devices โ€“ Android version 11 Samsung FE20 phone / Android version 8.1 Galaxy A10 tablet / iOS version 15 iPad Pro 5th generation / iOS version 15 iPhone 13 Pro Max.


Below are some screenshots of the survey on various browsers and devices:
(NOTE: please disregard blurriness of screenshots, this is due to device simulation and is not related to the code changes):

screenshot for Chrome 96 / Windows 10:

image.png (892ร—1 px, 133 KB)
image.png (881ร—1 px, 130 KB)


screenshot for Safari 15 / Mac OS Monterrey:

image.png (933ร—1 px, 347 KB)
image.png (933ร—1 px, 322 KB)


screenshot for iPhone 13 Pro Max / Mac iOS version 15:

image.png (887ร—422 px, 157 KB)
image.png (890ร—422 px, 167 KB)


screenshot for iPad Pro 5th generation / iOS version 15:

image.png (695ร—829 px, 222 KB)
image.png (698ร—817 px, 215 KB)