Page MenuHomePhabricator
Create Task
Maniphest T297579

Language button is not clickable in sticky headers when preference to disable compact language list is enabled
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To
ovasileva
Authored By
RolandUnger
Dec 13 2021, 6:06 AM
Tags
Referenced Files
F34923729: Screen Recording 2022-01-19 at 3.14.58 PM.mov.gif
Jan 19 2022, 11:15 PM
F34923727: Screen Recording 2022-01-19 at 3.14.26 PM.mov.gif
Jan 19 2022, 11:15 PM
F34923723: Screen Recording 2022-01-19 at 3.10.58 PM.mov.gif
Jan 19 2022, 11:12 PM
F34923721: Screen Recording 2022-01-19 at 3.09.49 PM.mov.gif
Jan 19 2022, 11:12 PM
F34891820: Screen Shot 2021-12-21 at 8.16.35 AM.png
Dec 21 2021, 4:31 PM
F34881774: sticky-header-languages.jpg
Dec 13 2021, 6:06 AM
Subscribers
Aklapper
bwang
cjming
Edtadros
Jdlrobson
• nray
RolandUnger

Description

This bug seems to be similar to T287191.

List of steps to reproduce (step by step, including full links if applicable):

sticky-header-languages.jpg (385×1 px, 88 KB)

What happens?:

  • No scollable language list appears. A list is shown only if you visit incognito the article.

What should have happened instead?:

  • Button should not appear / Button should do something

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

  • Firefox 95.0

QA steps

Visit preferences and uncheck this box:

Screen Shot 2021-12-21 at 8.16.35 AM.png (156×954 px, 24 KB)

Go to a page and get the sticky header to appear.
Expected: There is no language button in the sticky header.

  1. Visit preferences and check this box:
    Screen Shot 2021-12-21 at 8.16.35 AM.png (156×954 px, 24 KB)

Go to a page and get the sticky header to appear.
Expected: There is a language button in the sticky header and clicking language button should open a dialog in place without scrolling the page

QA Results - Beta

ACStatusDetails
1✅T297579#7635072
2✅T297579#7635072

QA Results - Prod

ACStatusDetails
1✅T297579#7635075
2✅T297579#7635075

Details

SubjectRepoBranchLines +/-
Hide language button in sticky header if compact links disabledmediawiki/skins/Vectormaster+7 -2
Drop ineffective rulemediawiki/extensions/UniversalLanguageSelectormaster+0 -6
Hide sticky header language button with preference disabledmediawiki/extensions/UniversalLanguageSelectormaster+7 -0
Ensure sticky header language button only shows when there are multiple languages and when ULS is enabledmediawiki/skins/Vectormaster+9 -7
If no ULS, hide language button in sticky headermediawiki/skins/Vectormaster+14 -0
Customize query in gerrit

Related Objects

Event Timeline

RolandUnger created this task.Dec 13 2021, 6:06 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 13 2021, 6:06 AM
RolandUnger added a subscriber: Jdlrobson.Dec 13 2021, 6:07 AM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2021-22); removed Local-Wiki-Template-And-Gadget-Issues, UniversalLanguageSelector.Dec 17 2021, 10:41 PM

If that's disabled we should probably also disable the language button in the sticky header. Thanks for reporting.

Jdlrobson renamed this task from Language button is not clickable in sticky headers to Language button is not clickable in sticky headers when preference to disable compact language list is enabled.Dec 20 2021, 4:22 PM
ovasileva triaged this task as High priority.Dec 20 2021, 5:50 PM
ovasileva updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)Dec 21 2021, 4:31 PM
Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
gerritbot added a comment.Dec 21 2021, 4:37 PM

Change 749212 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Language button clickable in sticky header with preference disabled

https://gerrit.wikimedia.org/r/749212

gerritbot added a project: Patch-For-Review.Dec 21 2021, 4:37 PM
LGoto moved this task from Incoming to Sticky header on the Desktop Improvements (Vector 2022) board.Jan 4 2022, 6:26 PM
Jdlrobson updated the task description. (Show Details)Jan 4 2022, 6:28 PM
LGoto set the point value for this task to 3.Jan 4 2022, 6:32 PM
LGoto moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 4 2022, 7:23 PM
gerritbot added a comment.Jan 5 2022, 12:11 AM

Change 751521 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Hide sticky header language button with preference disabled

https://gerrit.wikimedia.org/r/751521

gerritbot added a comment.Jan 5 2022, 12:11 AM

Change 749212 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] Language button clickable in sticky header with preference disabled

Reason:

Thinking about this some more I think this is a better solution: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/UniversalLanguageSelector/+/751521

https://gerrit.wikimedia.org/r/749212

Jdlrobson moved this task from Code Review to Blocked on Others on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 5 2022, 12:12 AM
gerritbot added a comment.Jan 5 2022, 4:19 PM

Change 749212 restored by Jdlrobson:

[mediawiki/skins/Vector@master] Language button clickable in sticky header with preference disabled

https://gerrit.wikimedia.org/r/749212

Jdlrobson moved this task from Blocked on Others to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 5 2022, 5:52 PM
cjming claimed this task.Jan 5 2022, 5:53 PM
gerritbot added a comment.Jan 6 2022, 5:13 AM

Change 751521 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Hide sticky header language button with preference disabled

https://gerrit.wikimedia.org/r/751521

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 6 2022, 6:00 AM
cjming removed cjming as the assignee of this task.Jan 6 2022, 5:34 PM
cjming moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming subscribed.
Jdlrobson moved this task from Needs More Work to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 6 2022, 6:09 PM
Jdlrobson assigned this task to cjming.Jan 7 2022, 1:22 AM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming reassigned this task from cjming to Edtadros.Jan 7 2022, 5:59 PM
cjming moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming reassigned this task from Edtadros to bwang.Jan 7 2022, 6:30 PM
cjming moved this task from QA to Doing on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
cjming added a subscriber: Edtadros.
bwang removed bwang as the assignee of this task.Jan 7 2022, 8:43 PM
bwang moved this task from Doing to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
bwang subscribed.
gerritbot added a comment.Jan 7 2022, 8:56 PM

Change 749212 abandoned by Jdlrobson:

[mediawiki/skins/Vector@master] If no ULS, hide language button in sticky header

Reason:

Being done in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/752003

https://gerrit.wikimedia.org/r/749212

gerritbot added a comment.Jan 7 2022, 8:57 PM

Change 752003 had a related patch set uploaded (by Jdlrobson; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure sticky header language button only shows when there are multiple languages and when ULS is enabled

https://gerrit.wikimedia.org/r/752003

gerritbot added a comment.Jan 7 2022, 9:02 PM

Change 752003 had a related patch set uploaded (by Bernard Wang; author: Bernard Wang):

[mediawiki/skins/Vector@master] Ensure sticky header language button only shows when there are multiple languages and when ULS is enabled

https://gerrit.wikimedia.org/r/752003

Jdlrobson updated the task description. (Show Details)Jan 7 2022, 11:23 PM
gerritbot added a comment.Jan 7 2022, 11:42 PM

Change 752003 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Ensure sticky header language button only shows when there are multiple languages and when ULS is enabled

https://gerrit.wikimedia.org/r/752003

Jdlrobson moved this task from Code Review to Needs More Work on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 8 2022, 12:20 AM

Needs more work. There seems to be a problem in the implementation here. I see the class on the body that says the feature is disabled but the skinStyle is not applying for some reason because the module is not in the page...

gerritbot added a comment.Jan 10 2022, 10:42 PM

Change 752754 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Hide language button in sticky header if compact links disabled

https://gerrit.wikimedia.org/r/752754

Jdlrobson moved this task from Needs More Work to Code Review on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 10 2022, 10:42 PM
gerritbot added a comment.Jan 10 2022, 10:46 PM

Change 752758 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/UniversalLanguageSelector@master] Drop ineffective rule

https://gerrit.wikimedia.org/r/752758

gerritbot added a comment.Jan 11 2022, 8:24 AM

Change 752758 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Drop ineffective rule

https://gerrit.wikimedia.org/r/752758

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.18; 2022-01-17); removed MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 11 2022, 9:00 AM
LGoto assigned this task to • nray.Jan 11 2022, 6:08 PM
gerritbot added a comment.Jan 11 2022, 9:22 PM

Change 752754 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Hide language button in sticky header if compact links disabled

https://gerrit.wikimedia.org/r/752754

Jdlrobson reassigned this task from • nray to Edtadros.Jan 11 2022, 9:52 PM
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.
Jdlrobson added a subscriber: • nray.
Edtadros moved this task from QA to QA in Prod on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.Jan 19 2022, 11:12 PM

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps
  1. Visit preferences and uncheck this box:
    Screen Shot 2021-12-21 at 8.16.35 AM.png (156×954 px, 24 KB)

Go to a page and get the sticky header to appear.
✅ AC1: Expected: There is no language button in the sticky header.

Screen Recording 2022-01-19 at 3.09.49 PM.mov.gif (290×800 px, 477 KB)

  1. Visit preferences and check this box:
    Screen Shot 2021-12-21 at 8.16.35 AM.png (156×954 px, 24 KB)

Go to a page and get the sticky header to appear.
✅ AC2: Expected: There is a language button in the sticky header and clicking language button should open a dialog in place without scrolling the page

Screen Recording 2022-01-19 at 3.10.58 PM.mov.gif (290×800 px, 550 KB)

Edtadros reassigned this task from Edtadros to ovasileva.Jan 19 2022, 11:15 PM
Edtadros moved this task from QA in Prod to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2021-22) board.

Test Result - Prod

Status: ✅ PASS
Environment: cawiki
OS: macOS Monterey
Browser: Chrome
Device: MBP
Emulated Device:NA

Test Artifact(s):

QA Steps
  1. Visit preferences and uncheck this box:
    Screen Shot 2021-12-21 at 8.16.35 AM.png (156×954 px, 24 KB)

Go to a page and get the sticky header to appear.
✅ AC1: Expected: There is no language button in the sticky header.

Screen Recording 2022-01-19 at 3.14.26 PM.mov.gif (290×800 px, 247 KB)

  1. Visit preferences and check this box:
    Screen Shot 2021-12-21 at 8.16.35 AM.png (156×954 px, 24 KB)

Go to a page and get the sticky header to appear.
✅ AC2: Expected: There is a language button in the sticky header and clicking language button should open a dialog in place without scrolling the page

Screen Recording 2022-01-19 at 3.14.58 PM.mov.gif (290×800 px, 411 KB)

Edtadros updated the task description. (Show Details)Jan 19 2022, 11:17 PM
ovasileva closed this task as Resolved.Jan 21 2022, 11:57 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL