Page MenuHomePhabricator
Create Task
Maniphest T297592

XTool error when viewing edit counter of certain users
Closed, ResolvedPublic1 Estimated Story PointsBUG REPORT
Actions

Description

Quick way to reproduce the error: Go to https://xtools.wmflabs.org/ec/en.wikipedia.org/Nigos

"Normal" way to reproduce error:

  1. Go to https://xtools.wmflabs.org/
  2. Click on "Edit Counter"
  3. Type "Nigos" on field "User"

XTools then spew out this error:

Argument 4 passed to AppBundle\Model\UserRights::setAutoRemovals() must be of the type array, null given, called in /var/www/src/AppBundle/Model/UserRights.php on line 265

I expected the program to provide statistics about the user. (Example of what would I expected)

The username is valid on Wikipedia (https://en.wikipedia.org/wiki/User:Nigos), and I have replicated this error on Firefox and Safari. This bug happens to both logged-in and logged-out users. This bug appeared every time I tried, no matter if I have cleared browser's cache.

XTools version: v.3.14.1 (r.a80978e9); Screenshot:

Screen Shot 2021-12-13 at 18.36.39.png (881×1 px, 313 KB)

Related Objects

Event Timeline

CactiStaccingCrane renamed this task from XTool bug when viewing edit counter of certain users to XTool error when viewing edit counter of certain users.Dec 13 2021, 11:38 AM
CactiStaccingCrane created this task.
CactiStaccingCrane moved this task from Backlog to Edit Counter on the XTools board.Dec 13 2021, 11:40 AM
MusikAnimal claimed this task.EditedDec 13 2021, 8:01 PM
MusikAnimal added a subscriber: MusikAnimal.

I saw the automated error reports and suspected this might be a widespread issue. Indeed it is. A recent change to how global user rights changes are logged is the culprit. XTools will break for any user who has had global rights changed since December 9. T41045, T138728 and T153322 are the relevant tasks for that change. A fix for XTools is coming ASAP :)

I'll detail what changes were made for others searching Phabricator for answers. After unserializing the log_params:

  • 4::oldgroups is now oldGroups
  • 5::newgroups is now newGroups
MusikAnimal triaged this task as Unbreak Now! priority.Dec 13 2021, 8:05 PM
MusikAnimal added a project: Community-Tech (CommTech-Sprint-15).
MusikAnimal set the point value for this task to 1.

Since this is a critical bug fix I'm going to put in Community-Tech's scope.

MusikAnimal moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Sprint-15) board.Dec 13 2021, 8:05 PM
MusikAnimal mentioned this in rXTde318f29018d: EditCounter: fix parsing of global user right schanges.Dec 13 2021, 8:09 PM
MusikAnimal lowered the priority of this task from Unbreak Now! to High.Dec 13 2021, 8:24 PM

Immediate issue has been fixed and deployed with v3.14.2. I'm going to leave this open while I investigate if there are any other upcoming breaking changes related to this.

MusikAnimal closed this task as Resolved.Dec 14 2021, 10:54 PM
MusikAnimal moved this task from In Development 💻 to Done 🏁 on the Community-Tech (CommTech-Sprint-15) board.

As far as I can tell we're in no immediate danger of further related changes breaking XTools. Closing as no QA is needed here.

MusikAnimal moved this task from Edit Counter to Complete on the XTools board.Dec 14 2021, 10:54 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL