Page MenuHomePhabricator
Create Task
Maniphest T29765

Postgresql: invalid input syntax for type timestamp (Semantic MW)
Closed, ResolvedPublic
Actions

Description

Author: anton.kochkov

Description:
On MediaWiki 1.16 and Semantic MediaWiki from svn on PostgreSQL 9.0.1 when i'm edit/create new page i'm always see this error:

A database error has occurred
Query: UPDATE page SET page_touched = '11012' WHERE page_namespace = '0' AND page_title = 'PPA'
Function: SMWStore::updateData
Error: 1 ERROR: invalid input syntax for type timestamp with time zone: "11012"
LINE 1: ...re::updateData XVilka */ page SET page_touched = '11012' WH...
^
Backtrace:
#0 /usr/home/droid-dev/www/includes/db/Database.php(538): DatabasePostgres->reportQueryError('ERROR: invalid...', 1, 'UPDATE page SE...', 'SMWStore::updat...', false)
#1 /usr/home/droid-dev/www/includes/db/Database.php(1212): DatabaseBase->query('UPDATE page SE...', 'SMWStore::updat...')
#2 /usr/home/droid-dev/www/extensions/SemanticMediaWiki/includes/storage/SMW_Store.php(238): DatabaseBase->update('page', Array, Array, 'SMWStore::updat...')
#3 /usr/home/droid-dev/www/extensions/SemanticMediaWiki/includes/SMW_ParseData.php(252): SMWStore->updateData(Object(SMWSemanticData))
#4 /usr/home/droid-dev/www/extensions/SemanticMediaWiki/includes/SMW_ParseData.php(406): SMWParseData::storeData(Object(ParserOutput), Object(Title), true)
#5 [internal function]: SMWParseData::onLinksUpdateConstructed(Object(LinksUpdate))
#6 /usr/home/droid-dev/www/includes/Hooks.php(133): call_user_func_array(Array, Array)
#7 /usr/home/droid-dev/www/includes/LinksUpdate.php(72): wfRunHooks('LinksUpdateCons...', Array)
#8 /usr/home/droid-dev/www/includes/Article.php(3317): LinksUpdate->LinksUpdate(Object(Title), Object(ParserOutput))
#9 /usr/home/droid-dev/www/includes/Article.php(2081): Article->editUpdates('== Primary Prot...', 'Created page wi...', true, '20110227174448', '953', true)
#10 /usr/home/droid-dev/www/includes/Article.php(1764): Article->doEdit('== Primary Prot...', '', 101)
#11 /usr/home/droid-dev/www/includes/EditPage.php(900): Article->insertNewArticle('== Primary Prot...', '', true, false, false, false, false)
#12 /usr/home/droid-dev/www/includes/EditPage.php(2552): EditPage->internalAttemptSave(false, false)
#13 /usr/home/droid-dev/www/includes/EditPage.php(389): EditPage->attemptSave()
#14 /usr/home/droid-dev/www/includes/EditPage.php(271): EditPage->edit()
#15 /usr/home/droid-dev/www/extensions/FCKeditor/FCKeditor.body.php(159): EditPage->submit()
#16 [internal function]: FCKeditor_MediaWiki->onCustomEditor(Object(Article), Object(User))
#17 /usr/home/droid-dev/www/includes/Hooks.php(133): call_user_func_array(Array, Array)
#18 /usr/home/droid-dev/www/includes/Wiki.php(545): wfRunHooks('CustomEditor', Array)
#19 /usr/home/droid-dev/www/includes/Wiki.php(70): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#20 /usr/home/droid-dev/www/index.php(117): MediaWiki->performRequestForTitle(Object(Title), Object(Article), Object(OutputPage), Object(User), Object(WebRequest))
#21 {main}

Version: unspecified
Severity: enhancement

Details

Reference
bz27765

Related Objects
Search...

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
· · ·
InvalidNoneT2384 [REPLACED BY TAG] PostgreSQL/pgsql support (tracking)
ResolvedJeroenDeDauwT29765 Postgresql: invalid input syntax for type timestamp (Semantic MW)
· · ·

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:27 PM
• bzimport added a project: MediaWiki-extensions-Semantic-MediaWiki.
• bzimport set Reference to bz27765.
• bzimport created this task.Feb 27 2011, 6:27 PM
• bzimport added a comment.Feb 27 2011, 6:28 PM

anton.kochkov wrote:

Also similar error was in this bug: https://bugzilla.wikimedia.org/show_bug.cgi?id=26295

JeroenDeDauw added a comment.Feb 27 2011, 6:34 PM

Thanks for reporting this. There are multiple known issues with the recent versions of SMW and PostGres. I will have a look at this as soon as the PostGres support of the MW 1.17 installer gets fixed.

mkroetzsch added a comment.Feb 27 2011, 8:18 PM

I note that this error relates to the recent AutoRefreshSubject extension in SMW. It might be that it is not specific to Postgres.

JeroenDeDauw added a comment.Feb 27 2011, 9:07 PM

How do you figure it's related to the AutoRefreshSubject stuff?

mkroetzsch added a comment.Feb 28 2011, 8:31 AM

Its in the bug report: it gives the lines where the SQL error came from. Moreover, SMW does usually not touch any MW tables, and the bug is about an insert in the "page" table. Is this really necessary?

JeroenDeDauw added a comment.Feb 28 2011, 2:46 PM

Indeed, now I see. It's an update to indicate the page cache is invalid (not an insert), and it's doing pretty much the same as the invalidation function in MW core, with the difference that the code in SMW is adding some number to the timestamp, to ensure it's bigger then the one at which the page is actually saved.

In any case, I'll have another go at the whole MW+SMW PostGres story tomorrow.

• bzimport added a comment.Apr 6 2011, 1:54 PM

p.j.kersten wrote:

FWIW, removing the extra addition on the timestamp in SMW_Store.php:238 makes it work again.

JeroenDeDauw added a comment.Apr 7 2011, 9:38 PM

I just changed the addition to only happen for mysql, should find a more decent fix later on though, because now the automatic refresh won't happen for postgres. Can you confirm the issue is 'fixed'?

• bzimport added a comment.Apr 8 2011, 12:55 PM

p.j.kersten wrote:

Your modification is the same as I did. It's working for me, without further verifying cache behavior.

• bzimport added a comment.Apr 9 2011, 7:59 PM

p.j.kersten wrote:

A better fix: SMW_Store.php +233
$dbw->update(

        'page',
        array( 'page_touched' => $dbw->timestamp(time() +9001) ),
        $title->pageCond(),
        __METHOD__
);

Seems to work as well and should fix the cache problem.

JeroenDeDauw added a comment.Apr 9 2011, 8:12 PM

Ah, nice, thanks :) Just committed that

• bzimport added a comment.Jul 27 2011, 8:33 PM

plewe wrote:

This wasn't an issue in SMW 1.5.4, but seems to have reappeared in 1.5.6; when I put Pieter Kersten's patch back into SMW_Store.php, it works fine. Please check this for 1.6.

JeroenDeDauw added a comment.Jul 27 2011, 10:15 PM

(In reply to comment #12)

This wasn't an issue in SMW 1.5.4, but seems to have reappeared in 1.5.6; when
I put Pieter Kersten's patch back into SMW_Store.php, it works fine. Please
check this for 1.6.

I'm not sure what you are referring to. Please elaborate or open a new bug report.

• bzimport added a comment.Jul 29 2011, 3:34 AM

plewe wrote:

I mean that I started seeing this bug when I upgraded SMW to 1.5.6. I was not seeing it in 1.5.4. I assume in April you committed Pieter's patch into what became 1.5.4, but somehow 1.5.6 had the older code. I was able to put the patch back in, and it worked. I just was hoping someone could check the code for SMW 1.6 to make sure the patched code is there.

JeroenDeDauw added a comment.Jul 29 2011, 3:34 PM

The patch might have been reverted due to side effects. I don't really remember, so will have to look into this further. I really can't make this change and risk introducing this side effect at this point, as SMW 1.6 is planned to be released tomorrow. I'll look at it after the release.

Jdforrester-WMF added a project: PostgreSQL.Nov 2 2016, 8:16 PM
Jdforrester-WMF subscribed.

Migrating from the old tracking task to a tag for PostgreSQL-related tasks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL