TypeError: undefined is not an object (evaluating 'task.token')
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Sgs
	Dec 13 2021, 11:17 PM

Description

Error

mwversion: undefined
reqId: undefined
Find reqId in Logstash

normalized_message

TypeError: undefined is not an object (evaluating 'task.token')

exception.trace

at https://fr.m.wikipedia.org/w/load.php?lang=fr&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%7Coojs-ui-windows.icons&skin=minerva&version=j6oz2:162:261
at https://fr.m.wikipedia.org/w/load.php?lang=fr&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%7Coojs-ui-windows.icons&skin=minerva&version=j6oz2:113:212
at https://fr.m.wikipedia.org/w/load.php?lang=fr&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%7Coojs-ui-windows.icons&skin=minerva&version=j6oz2:118:217
at https://fr.m.wikipedia.org/w/load.php?lang=fr&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%7Coojs-ui-windows.icons&skin=minerva&version=j6oz2:120:285
at dispatch https://fr.m.wikipedia.org/w/load.php?lang=fr&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%7Coojs-ui-windows.icons&skin=minerva&version=j6oz2:273:265

Impact

Notes

Example 1

at NewcomerTaskLogger.log  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.HelpPanel.init%7Cext.growthExperiments.Homepage.Impact%2CLogger%2CLogging%2CMentorship%2CRecentQuestions%2CStartEditing%2CSuggestedEdits%7Cext.guidedTour.tour.homepage_welcome%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.router&skin=vector&version=412ez:136:535
at SuggestedEditsModule.logCardData  https://en.wikipedia.org/w/load.php?lang=en&modules=ext.growthExperiments.HelpPanel.init%7Cext.growthExperiments.Homepage.Impact%2CLogger%2CLogging%2CMentorship%2CRecentQuestions%2CStartEditing%2CSuggestedEdits%7Cext.guidedTour.tour.homepage_welcome%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.router&skin=vector&version=412ez:87:535

Example 2

at NewcomerTaskLogger.log https://ar.m.wikipedia.org/w/load.php?lang=ar&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=minerva&version=cdsnt:168:535 at SuggestedEditsModule.logCardData https://ar.m.wikipedia.org/w/load.php?lang=ar&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=minerva&version=cdsnt:119:535 at SuggestedEditsModule.logEditTaskClick https://ar.m.wikipedia.org/w/load.php?lang=ar&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=minerva&version=cdsnt:124:527 at SuggestedEditsModule.<anonymous> https://ar.m.wikipedia.org/w/load.php?lang=ar&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=minerva&version=cdsnt:124:959 at HTMLAnchorElement.dispatch https://ar.m.wikipedia.org/w/load.php?lang=ar&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=minerva&version=cdsnt:284:260 at HTMLAnchorElement.elemData.handle https://ar.m.wikipedia.org/w/load.php?lang=ar&modules=ext.growthExperiments.Homepage.Discovery.scripts%7Cext.growthExperiments.Homepage.Logger%2CLogging%2CMobile%2CStartEditing%2CSuggestedEdits%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets&skin=minerva&version=cdsnt:280:877

Steps to reproduce:

On Special:Homepage (desktop) or suggested edits overlay (mobile), open suggested edits filter
Make a selection and click done
While the action is in progress (ellipsis shown at the bottom of the filter), close the filter
Click on the task card

Screen recording:

Details

	Subject	Repo	Branch	Lines +/-
	Suggested Edits: Close the filters dialog after the task feed has been updated	mediawiki/extensions/GrowthExperiments	master	+157 -105

Customize query in gerrit

Related Objects

Mentioned In: T244928: [wmf.18] Suggested edits - when filters are changed, "No suggestions found" briefly displayed when a user navigates between articles
Mentioned Here: T296043: TypeError: undefined is not an object (evaluating 'this.currentCard.data.qualityGateIds')

Event Timeline

Sgs created this task.Dec 13 2021, 11:17 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 13 2021, 11:17 PM

Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Dec 16 2021, 2:36 AM

Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

Tgr merged a task: T297658: TypeError: Cannot read property 'token' of undefined.Dec 16 2021, 3:15 AM

This seems to be thrown at the beginning of NewcomerTaskLogger.log (although the line number is off by one, but maybe the code in master changed since the branch cut?) when called from SuggestedEditsModule.logCardData.

Sgs claimed this task.Dec 16 2021, 5:30 PM

Sgs moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

This might be the same issue as T296043: TypeError: undefined is not an object (evaluating 'this.currentCard.data.qualityGateIds'), where the edit button widget was disabled, but the event listener was on the button element so the click was logged when it wasn't supposed to. The issue was was fixed in wmf12, which was released on Dec 9, but was rolled back. Looking at the last 30 days, this error was more frequent prior and the latest was from Dec 13 (which was when wmf12 was released again).

Sgs removed Sgs as the assignee of this task.Dec 16 2021, 6:07 PM

@Etonkovidova FYI I'm moving this to test in production in case this error comes up even with wmf12.

Checked after wmf.13 deployment - no errors. The last timestamp for the error is Dec 13, 2021 @ 12:13:31.691 (https://logstash.wikimedia.org/goto/39dc6d3472afab42371e5e15c3b3a47c)

Re-opening since this error came up once on Dec 17, permalink: https://logstash.wikimedia.org/goto/7b6dfc00b166bc9d9d45e2e9aa465a44

Umherirrender added a project: JavaScript.Dec 18 2021, 4:00 PM

Looking at the errors from Dec 17 to today, the majority of the errors are from mobile with more errors coming from logEditTaskClick (which on mobile could be either clicking on the edit button or the task card in the suggested edits module).

• mewoph updated the task description. (Show Details)Jan 11 2022, 7:16 PM

• mewoph updated the task description. (Show Details)

Krinkle moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Jan 11 2022, 11:44 PM

Change 753580 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Close the filters dialog after the task feed has been updated

https://gerrit.wikimedia.org/r/753580

gerritbot added a project: Patch-For-Review.Jan 12 2022, 11:17 PM

Updated the filters dialog to close after the task feed have been updated — I think this would make the experience less confusing for users since before this change, some users would see the old task feed while the API request is in progress before it got replaced by the new feed)

Mobile

Desktop

• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 12 2022, 11:26 PM

• mewoph mentioned this in T244928: [wmf.18] Suggested edits - when filters are changed, "No suggestions found" briefly displayed when a user navigates between articles.Jan 18 2022, 7:01 PM

• mewoph merged a task: T244928: [wmf.18] Suggested edits - when filters are changed, "No suggestions found" briefly displayed when a user navigates between articles.

• mewoph added subscribers: revi, kostajh, MMiller_WMF.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 25 2022, 12:17 PM

Change 753580 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Suggested Edits: Close the filters dialog after the task feed has been updated

https://gerrit.wikimedia.org/r/753580

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 25 2022, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 25 2022, 1:10 PM

Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 27 2022, 11:29 PM

Checked on wmf.20 - the last error (and the only one for 30 days) was recorded on Jan 27/2022 before the patch was deployed (https://logstash.wikimedia.org/goto/39dc6d3472afab42371e5e15c3b3a47c).

Also checked for

triggering for the error
general change filter functionality

All looked as expected.

	F34916118: suggestededitsFilters_loading.gif
	Jan 12 2022, 11:23 PM

TypeError: undefined is not an object (evaluating 'task.token')Closed, ResolvedPublicPRODUCTION ERRORActions