Page MenuHomePhabricator

Remove multiple instance of VUEX initialization
Closed, ResolvedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

What happens?:

  • the console gives an error of [vuex] already installed. Vue.use(Vuex) should be called only once.

What should have happened instead?:

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

Change 747100 had a related patch set uploaded (by Simone Cuomo; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@master] Remove multiple instance of VUEX initialization

https://gerrit.wikimedia.org/r/747100

Change 747100 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@master] Remove multiple instance of VUEX initialization

https://gerrit.wikimedia.org/r/747100

Change 747081 had a related patch set uploaded (by Eric Gardner; author: Simone Cuomo):

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.13] Remove multiple instance of VUEX initialization

https://gerrit.wikimedia.org/r/747081

Change 747081 merged by jenkins-bot:

[mediawiki/extensions/MediaSearch@wmf/1.38.0-wmf.13] Remove multiple instance of VUEX initialization

https://gerrit.wikimedia.org/r/747081

Mentioned in SAL (#wikimedia-operations) [2021-12-15T00:31:15Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.13/extensions/MediaSearch/resources/store/index.js: Backport: [[gerrit:747081|Remove multiple instance of VUEX initialization (T297690)]] (duration: 01m 04s)

Assuming this task is about the MediaSearch code project, hence adding that project tag so other people who don't know or don't care about team tags can also find this task when searching via projects. Please set appropriate project tags when possible. Thanks.

To verify: Viewing Special:MediaSearch with ?debug=true params should not display any errors about [vuex] already installed. There will be a number of other deprecation warnings (not errors) visible in Debug mode but that is expected as part of the Vue 2 -> Vue 3 migration (these are harmless and can be fixed later).

Etonkovidova subscribed.

Checked on commons wmf.13 - the issue is fixed.

To verify: Viewing Special:MediaSearch with ?debug=true params should not display any errors about [vuex] already installed. There will be a number of other deprecation warnings (not errors) visible in Debug mode but that is expected as part of the Vue 2 -> Vue 3 migration (these are harmless and can be fixed later).

Yes, quite few vue warnings are still present.