Hello @phuedx , we have questions regarding the process of this ticket, especially around the choice of the hook handler (PageSaveComplete. vs RevisionFromEditComplete) and the job running by a Cron
Thank you!

cc @Tchanders maybe?

In T297701#7583978, @AGueyte wrote:

Hello @phuedx , we have questions regarding the process of this ticket, especially around the choice of the hook handler (PageSaveComplete. vs RevisionFromEditComplete) and the job running by a Cron

I reached for the PageSaveComplete hook reflexively as I've used it before. The RevisionFromEditComplete hook also seems like a good candidate. From a very brief glance, I can't see a case where one hook would be called but the other wouldn't. We should make sure whichever hook is chosen covers that cases where a row is inserted into the ip_changes table. That investigation could be captured as part of this task or in a separate spike. I'll be bold an suggest the former but I defer to team's judgement during their next AHaT Estimation meeting.

Re. running the job: My recommendation is/was to leverage MediaWiki's Job Queue rather than using cron. By enqueuing a short-lived job to update the table in a hook handler, we keep the table very-nearly-almost up to date without negatively impacting performance for logged-out users.

In T297701#7595475, @phuedx wrote:

Re. running the job: My recommendation is/was to leverage MediaWiki's Job Queue rather than using cron. By enqueuing a short-lived job to update the table in a hook handler, we keep the table very-nearly-almost up to date without negatively impacting performance for logged-out users.

We are going to have to write a maintenance script to bootstrap the table. This should be captured in a task.

@phuedx how does wikishared database work and are there any examples of tools already using it that can be linked to this ticket ?

In T297701#7609995, @TThoabala wrote:

@phuedx how does wikishared database work and are there any examples of tools already using it that can be linked to this ticket?

It's just another production database, which is used by several tools to store global information. We can connect to the wikishared database in the same way that we connect to production databases for other wikis:

// Elsewhere...
$centralDB = 'wikishared';

$services = \MediaWiki\MediaWikiServices::getInstance();
$loadBalancer = MediaWikiServices::getInstance()
  ->getDBLoadBalancerFactory()
  ->getMainLB( $centralDB );
$dbw = $loadBalancer->getConnectionRef( DB_PRIMARY );
$dbr = $loadBalancer->getConnectionRef( DB_REPLICA );

I looked here for examples of other codebases that use the database in production and found:

• https://www.mediawiki.org/wiki/Extension:UrlShortener
• https://www.mediawiki.org/wiki/Extension:BounceHandler
• https://www.mediawiki.org/wiki/Extension:Echo
• https://www.mediawiki.org/wiki/Extension:ContentTranslation
• https://www.mediawiki.org/wiki/Extension:ReadingLists
• https://www.mediawiki.org/wiki/Extension:WikimediaEditorTasks