Page MenuHomePhabricator
Create Task
Maniphest T297706

Stop using WikiPage::factory() in Wikibase
Closed, ResolvedPublic
Actions

Description

See parent task for details. (The WikiPage::newFrom*() methods aren’t used in Wikibase, only factory().) Let’s make this a separate task so we can tackle the calls in separate changes.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove backwards compatibility code from WikiPagePropertyOrderProvidermediawiki/extensions/Wikibasemaster+2 -10
Stop calling WikiPage::factory() in WikiPageEntityStoremediawiki/extensions/Wikibasemaster+41 -24
Pass WikiPageFactory into WikiPagePropertyOrderProvidermediawiki/extensions/WikibaseMediaInfomaster+1 -0
Stop using WikiPage::factory() in EditFilterHookRunnermediawiki/extensions/Wikibasemaster+12 -2
Stop using WikiPage::factory in SubmitEntityActionmediawiki/extensions/Wikibasemaster+2 -2
Stop using WikiPage::factory() in testsmediawiki/extensions/Wikibasemaster+12 -19
Stop using WikiPage::factory() in order providersmediawiki/extensions/Wikibasemaster+46 -9
Stop using WikiPage::factory() in EchoNotificationsHandlersmediawiki/extensions/Wikibasemaster+19 -12
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Dec 14 2021, 3:31 PM
gerritbot added a comment.Dec 14 2021, 3:45 PM

Change 747141 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory() in EchoNotificationsHandlers

https://gerrit.wikimedia.org/r/747141

gerritbot added a project: Patch-For-Review.Dec 14 2021, 3:45 PM
gerritbot added a comment.Dec 14 2021, 3:57 PM

Change 747146 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::getFactory() in tests

https://gerrit.wikimedia.org/r/747146

gerritbot added a comment.Dec 14 2021, 4:22 PM

Change 747158 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory() in order providers

https://gerrit.wikimedia.org/r/747158

gerritbot added a comment.Dec 14 2021, 4:33 PM

Change 747161 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory in SubmitEntityAction

https://gerrit.wikimedia.org/r/747161

gerritbot added a comment.Dec 14 2021, 4:33 PM

Change 747162 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory() in EditFilterHookRunner

https://gerrit.wikimedia.org/r/747162

gerritbot added a comment.Dec 14 2021, 5:50 PM

Change 747178 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Stop calling WikiPage::factory() in WikiPageEntityStore

https://gerrit.wikimedia.org/r/747178

gerritbot added a comment.Dec 14 2021, 5:50 PM

Change 747179 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseMediaInfo@master] Pass WikiPageFactory into WikiPagePropertyOrderProvider

https://gerrit.wikimedia.org/r/747179

gerritbot added a comment.Dec 14 2021, 5:51 PM

Change 747180 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Remove backwards compatibility code from WikiPagePropertyOrderProvider

https://gerrit.wikimedia.org/r/747180

Lucas_Werkmeister_WMDE claimed this task.Dec 14 2021, 5:51 PM
gerritbot added a comment.Dec 16 2021, 4:27 PM

Change 747141 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory() in EchoNotificationsHandlers

https://gerrit.wikimedia.org/r/747141

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 16 2021, 5:00 PM
gerritbot added a comment.Dec 16 2021, 5:27 PM

Change 747146 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory() in tests

https://gerrit.wikimedia.org/r/747146

gerritbot added a comment.Dec 16 2021, 5:27 PM

Change 747158 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory() in order providers

https://gerrit.wikimedia.org/r/747158

gerritbot added a comment.Dec 16 2021, 11:40 PM

Change 747161 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory in SubmitEntityAction

https://gerrit.wikimedia.org/r/747161

gerritbot added a comment.Dec 18 2021, 4:53 PM

Change 747162 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop using WikiPage::factory() in EditFilterHookRunner

https://gerrit.wikimedia.org/r/747162

gerritbot added a comment.Jan 6 2022, 1:10 PM

Change 747179 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] Pass WikiPageFactory into WikiPagePropertyOrderProvider

https://gerrit.wikimedia.org/r/747179

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.17; 2022-01-10); removed MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Jan 6 2022, 2:00 PM
gerritbot added a comment.Jan 7 2022, 1:01 PM

Change 747178 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Stop calling WikiPage::factory() in WikiPageEntityStore

https://gerrit.wikimedia.org/r/747178

gerritbot added a comment.Jan 7 2022, 1:01 PM

Change 747180 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Remove backwards compatibility code from WikiPagePropertyOrderProvider

https://gerrit.wikimedia.org/r/747180

Lucas_Werkmeister_WMDE closed this task as Resolved.Jan 7 2022, 1:17 PM
Lucas_Werkmeister_WMDE moved this task from Untriaged to 2021 | MW 1.36 / 1.37 on the Technical-Debt (Deprecation process) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits