Page tabs like "Edit", "View history" do not appear on Special:WhatLinksHere
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matmarex
	Dec 14 2021, 6:57 PM

Description

Page tabs like "Edit", "View history" do not appear on Special:WhatLinksHere.

Steps to reproduce:

Visit any page, e.g. https://en.wikipedia.org/wiki/The_Fighting_Temeraire
1. Note the full set of page tabs (which ones appear depends on your user preferences, but you should always see "Edit" and "View history")
Click "What links here" in the sidebar, landing on https://en.wikipedia.org/wiki/Special:WhatLinksHere/The_Fighting_Temeraire
1. Expected: The same set of tabs
2. Actual: Only a "Read" tab

This affects every skin, not just Vector. According to git bisect, seems to be caused by rMWef458e894888: Replace deprecated methods IContextSource::getWikiPage && IContextSource… / https://gerrit.wikimedia.org/r/c/mediawiki/core/+/702614.

Details

Related Changes in Gerrit:

Subject	Repo	Branch	Lines +/-
Replace deprecated IContextSource methods (attempt #2)	mediawiki/core	master	+61 -56
Revert "Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage"	mediawiki/core	wmf/1.38.0-wmf.12	+56 -61
Revert "Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage"	mediawiki/core	wmf/1.38.0-wmf.13	+56 -61
Revert "Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage"	mediawiki/core	master	+56 -61

Customize query in gerrit

Related Objects

Mentioned In: T275710: Deprecate IContextSource::getWikiPage and IContextSource::canUseWikiPage
T293953: 1.38.0-wmf.12 deployment blockers
Mentioned Here: T293953: 1.38.0-wmf.12 deployment blockers
rMWef458e894888: Replace deprecated methods IContextSource::getWikiPage && IContextSource…

Event Timeline

matmarex created this task.Dec 14 2021, 6:57 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 14 2021, 6:57 PM

(Originally reported at https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Edit_from_%22What_links_here%22 and T293953#7570356)

Rummskartoffel subscribed.Dec 14 2021, 7:07 PM

matmarex updated the task description. (Show Details)Dec 14 2021, 7:10 PM

Xaosflux added a project: Regression.Dec 14 2021, 7:56 PM

Change 747077 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747077

gerritbot added a project: Patch-For-Review.Dec 14 2021, 8:34 PM

Change 747077 merged by jenkins-bot:

[mediawiki/core@master] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747077

Change 747079 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@wmf/1.38.0-wmf.13] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747079

Change 747080 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@wmf/1.38.0-wmf.12] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747080

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 14 2021, 10:00 PM

Conceptually, having page tabs like "Edit", "View history" on a special page is a strange thing - usually, they relate to the current page. In case of the special page, they do not. This to me indicates that WhatLinksHere shouldn't be a special page, but a page action. On the other hand, page actions can't conveniently be linked...

Change 747079 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.13] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747079

Change 747080 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.12] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747080

Mentioned in SAL (#wikimedia-operations) [2021-12-15T00:26:02Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.12/includes/: Backport: [[gerrit:747080|Revert "Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage" (T297744)]] (duration: 01m 11s)

Mentioned in SAL (#wikimedia-operations) [2021-12-15T00:28:11Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.13/includes/: Backport: [[gerrit:747079|Revert "Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage" (T297744)]] (duration: 01m 12s)

Patches have been backported and deployed.

In T297744#7571180, @daniel wrote:

Conceptually, having page tabs like "Edit", "View history" on a special page is a strange thing - usually, they relate to the current page. In case of the special page, they do not. This to me indicates that WhatLinksHere shouldn't be a special page, but a page action. On the other hand, page actions can't conveniently be linked...

https://en.wikipedia.org/wiki/Special:RecentChangesLinked/Main_Page has the same tab behavior too FWIW. I do think the current distinction between special pages and actions makes little sense, https://www.mediawiki.org/wiki/Requests_for_comment/Drop_actions_in_favour_of_page_views_and_special_pages seemed like a good idea at the time (and even addresses this inconsistent tab behavior). Most actions now have special page redirects to make linking easier.

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.12; 2021-12-06); removed MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 15 2021, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Dec 15 2021, 1:10 AM

Change 747227 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Replace deprecated IContextSource methods (attempt #2)

https://gerrit.wikimedia.org/r/747227

gerritbot added a project: Patch-For-Review.Dec 15 2021, 3:37 AM