Page MenuHomePhabricator

Page tabs like "Edit", "View history" do not appear on Special:WhatLinksHere
Closed, ResolvedPublic

Description

Page tabs like "Edit", "View history" do not appear on Special:WhatLinksHere.

Steps to reproduce:

  1. Visit any page, e.g. https://en.wikipedia.org/wiki/The_Fighting_Temeraire
    1. Note the full set of page tabs (which ones appear depends on your user preferences, but you should always see "Edit" and "View history")
      image.png (2×3 px, 1 MB)
  2. Click "What links here" in the sidebar, landing on https://en.wikipedia.org/wiki/Special:WhatLinksHere/The_Fighting_Temeraire
    1. Expected: The same set of tabs
    2. Actual: Only a "Read" tab
      image.png (2×3 px, 340 KB)

This affects every skin, not just Vector. According to git bisect, seems to be caused by rMWef458e894888: Replace deprecated methods IContextSource::getWikiPage && IContextSource… / https://gerrit.wikimedia.org/r/c/mediawiki/core/+/702614.

Event Timeline

Change 747077 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@master] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747077

Change 747077 merged by jenkins-bot:

[mediawiki/core@master] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747077

Change 747079 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@wmf/1.38.0-wmf.13] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747079

Change 747080 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/core@wmf/1.38.0-wmf.12] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747080

Conceptually, having page tabs like "Edit", "View history" on a special page is a strange thing - usually, they relate to the current page. In case of the special page, they do not. This to me indicates that WhatLinksHere shouldn't be a special page, but a page action. On the other hand, page actions can't conveniently be linked...

Change 747079 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.13] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747079

Change 747080 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.12] Revert \"Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage\"

https://gerrit.wikimedia.org/r/747080

Mentioned in SAL (#wikimedia-operations) [2021-12-15T00:26:02Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.12/includes/: Backport: [[gerrit:747080|Revert "Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage" (T297744)]] (duration: 01m 11s)

Mentioned in SAL (#wikimedia-operations) [2021-12-15T00:28:11Z] <catrope@deploy1002> Synchronized php-1.38.0-wmf.13/includes/: Backport: [[gerrit:747079|Revert "Replace deprecated methods IContextSource::getWikiPage && IContextSource::canUseWikiPage" (T297744)]] (duration: 01m 12s)

Legoktm claimed this task.
Legoktm subscribed.

Patches have been backported and deployed.

Conceptually, having page tabs like "Edit", "View history" on a special page is a strange thing - usually, they relate to the current page. In case of the special page, they do not. This to me indicates that WhatLinksHere shouldn't be a special page, but a page action. On the other hand, page actions can't conveniently be linked...

https://en.wikipedia.org/wiki/Special:RecentChangesLinked/Main_Page has the same tab behavior too FWIW. I do think the current distinction between special pages and actions makes little sense, https://www.mediawiki.org/wiki/Requests_for_comment/Drop_actions_in_favour_of_page_views_and_special_pages seemed like a good idea at the time (and even addresses this inconsistent tab behavior). Most actions now have special page redirects to make linking easier.

Change 747227 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/core@master] Replace deprecated IContextSource methods (attempt #2)

https://gerrit.wikimedia.org/r/747227