TypeError: undefined is not an object (evaluating 'el. _leaflet_pos') at _getMapPanePos
Open, HighPublic2 Estimated Story PointsBUG REPORT
Actions

Assigned To

None

Authored By

	Jdlrobson
	Dec 15 2021, 11:09 PM

Description

New error appearing since 9th December

Errors in the form "TypeError: Cannot read properties of undefined (reading '_leaflet_pos') ", TypeError: Cannot read property '_leaflet_pos' of undefined , TypeError: undefined is not an object (evaluating 'el. _leaflet_pos')

236 in last 24hrs
https://logstash.wikimedia.org/goto/b51e1f7372df07d9caa13f20856a855c

at getPosition  URL1:80:1
at NewClass._getMapPanePos  URL1:109:749
at NewClass._getNewPixelOrigin  URL1:110:216
at NewClass._move  URL1:105:956

URL1: https://ru.m.wikipedia.org/w/load.php?lang=ru&modules=ext.kartographer.dialog%7Cmapbox%2Coojs-ui-core%2Coojs-ui-widgets%2Coojs-ui-windows%7Coojs-ui-core.icons%2Cstyles%7Coojs-ui-widgets.icons%7Coojs-ui-windows.icons%7Coojs-ui.styles.icons-interactions%2Cindicators&skin=minerva&version=1vr0u

Details

	Subject	Repo	Branch	Lines +/-
	Disable BoxZoom event as well when fullscreen map closes	mediawiki/extensions/Kartographer	master	+4 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Open	BUG REPORT	None	T297848 TypeError: undefined is not an object (evaluating 'el. _leaflet_pos') at _getMapPanePos
		Resolved		None	T327097 Add refresh button for nearby markers instead of autoloading

Event Timeline

Jdlrobson created this task.Dec 15 2021, 11:09 PM

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 15 2021, 11:09 PM

Jdlrobson moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Dec 15 2021, 11:10 PM

Umherirrender added a project: JavaScript.Dec 18 2021, 4:08 PM

I ran into something simliar to this in development.

getPosition — mapbox-lib.js:5023
_getMapPanePos — mapbox-lib.js:7034
_moved — mapbox-lib.js:7038
getCenter — mapbox-lib.js:6399
(anonymous function) — load.php:71   
mightThrow — jquery.js:3766
(anonymous function) — jquery.js:3834

This trigger from the getCenter() when closing the fullscreen dialog (where we reset the position of the dynamic parent map). Probably the fullscreen map didn't finish loading in this particular case.

instance.closing.then(function() {
    if (map.parentMap) {
        // FIXME we need to correct for the footerbar offset
        map.parentMap.setView(
        map.getCenter(),
        map.getZoom()
        );
    }
});

The render function of the index.js of dialog module.

This error appears as either "TypeError: Cannot read properties of undefined (reading '_leaflet_pos') " or "TypeError: undefined is not an object (evaluating 'el. _leaflet_pos') ". Combined error rate is 2111 errors per week, making this one of our top 3 errors by volume.

Jdlrobson mentioned this in T320613: [beta cluster] Enable new Kartographer Nearby on minerva.Oct 20 2022, 10:08 PM

I just had another instance of this, and this time, it was because I tried to click the X to exit fullscreen, but at the same time I accidentally zoomed (because I hit the scroll wheel) and the map was still in the transition of the zoom as it got closed.

[Error] TypeError: undefined is not an object (evaluating 'el.
_leaflet_pos')
	getPosition (load.php:87:992)
	_getMapPanePos (load.php:117:761)
	_getNewPixelOrigin (load.php:118:231)
	_move (load.php:113:975)
	_onZoomTransitionEnd (load.php:122:700)
	_onZoomTransitionEnd

awight added a project: WMDE-TechWish-Sprint-2023-01-18.Jan 20 2023, 8:27 AM

I suspect this is the same issue as in T316431: JavaScript error every time when closing a fullscreen map (same error about "reading _leaflet_pos"), but maybe in a differnet place in the code that was not touched as part of T316431.

WMDE-Fisch claimed this task.Jan 26 2023, 8:16 AM

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2023-01-18 board.

The issue is clearly coming from the autoreload part in the nearby feature. So when you move the map or zoom and quickly close it the events that listen to zoom and move try to execute an updated while the map is already destroyed.

Since we're planing to remove the autoreload feature anyways with the next changes. These issues should be gone with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Kartographer/+/881896 is merged.

WMDE-Fisch added a subtask: T327097: Add refresh button for nearby markers instead of autoloading .Jan 26 2023, 8:43 AM

Jdlrobson awarded a token.Jan 26 2023, 10:46 PM

Issues should be gone.

WMDE-Fisch closed subtask T327097: Add refresh button for nearby markers instead of autoloading as Resolved.Feb 13 2023, 1:36 PM

thiemowmde mentioned this in T297519: TypeError: undefined is not an object (evaluating 'el.classList').Mar 6 2023, 10:17 PM

Still occurring and I think I managed to replicate the issue.

On Safari (replicated on Mac OX) go to https://de.m.wikipedia.org/wiki/Masuren click map
Hold shift and draw box with left mouse link
Click escape button on keyboard before exiting.

This may relate to T297519.

Change 902673 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Kartographer@master] Disable BoxZoom event as well when fullscreen map closes

https://gerrit.wikimedia.org/r/902673

gerritbot added a project: Patch-For-Review.Mar 24 2023, 9:50 AM

Uh, I have never seen this box. Turns out it's a Leaflet feature, called "BoxZoom". Hold Shift, draw this box, and the map will zoom into the selected area. When I press Esc while I still hold down the Shift key I can reproduce the issue in all browsers. I made another patch.

thiemowmde moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2023-03-14 board.Mar 24 2023, 9:52 AM

thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.

thiemowmde moved this task from Backlog to In sprint on the WMDE-GeoInfo-FocusArea board.

Change 902673 merged by jenkins-bot:

[mediawiki/extensions/Kartographer@master] Disable BoxZoom event as well when fullscreen map closes

https://gerrit.wikimedia.org/r/902673

Maintenance_bot removed a project: Patch-For-Review.Mar 24 2023, 12:30 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.2; 2023-03-27).Mar 24 2023, 1:00 PM

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2023-03-14 board.Mar 27 2023, 10:28 AM

My understanding is this went out with wmf2, but I'm not seeing any change in the error rate, so my replication wasn't the exact same as the issue we're seeing here :-(

thiemowmde moved this task from Done to Watching / Epic / Stalled on the WMDE-TechWish-Sprint-2023-03-14 board.Apr 4 2023, 9:01 AM

thiemowmde removed thiemowmde as the assignee of this task.Apr 5 2023, 7:40 AM

WMDE-Fisch moved this task from In progress to Backlog on the WMDE-TechWish-Maintenance board.Dec 21 2023, 8:23 AM

Krinkle moved this task from Dec 2021 to Older on the Wikimedia-production-error board.Feb 22 2024, 10:17 PM