Page MenuHomePhabricator

Unable to reply when there are comments with the same timestamp, one transcluded and one not
Closed, ResolvedPublic

Description

Unable to reply when there are comments with the same timestamp, one transcluded and one not.

Original report with more details: https://www.mediawiki.org/w/index.php?title=Topic:Wm6gxgk7mmtnzhfo&topic_showPostId=wm6m6zhrtsrvjn8d#flow-post-wm6m6zhrtsrvjn8d

I'm getting the same error on the reply link after "Please review my request and I am ready to join a discussion regarding this ..." at the very bottom of https://en.wikipedia.org/w/index.php?title=User_talk:Haoreima&oldid=1060292141#3rd_unblock_request_after_2nd_procedural_decline

This case is interesting. There are two comments with the same time (16:13, 14 December 2021 (UTC)), where the first of them is generated by the {{Unblock}} template, but the second isn't.

Reply tool can't add replies to comments inside template parameters, so we can't reply to the first one, but we should be able to reply to the second – but we can't. I think something might be going wrong with that check, and it checks the first comment even if you're replying to the second one.

Event Timeline

Change 747645 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix replying when comments with the same name have different transclusion data

https://gerrit.wikimedia.org/r/747645

Change 747645 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix replying when comments with the same name have different transclusion data

https://gerrit.wikimedia.org/r/747645