Page MenuHomePhabricator
Create Task
Maniphest T297855

Session user loaded before session set up in GrowthExperimentsMentorManager service
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

/srv/mediawiki/php-1.38.0-wmf.13/includes/user/User.php:380
User::loadFromSession called before the end of Setup.php
from /srv/mediawiki/php-1.38.0-wmf.13/includes/user/User.php(380)
#0 /srv/mediawiki/php-1.38.0-wmf.13/includes/user/User.php(1893): User->load()
#1 /srv/mediawiki/php-1.38.0-wmf.13/includes/user/User.php(2529): User->getId()
#2 /srv/mediawiki/php-1.38.0-wmf.13/includes/user/UserOptionsManager.php(644): User->isRegistered()
#3 /srv/mediawiki/php-1.38.0-wmf.13/includes/user/UserOptionsManager.php(594): MediaWiki\User\UserOptionsManager->getCacheKey(User)
#4 /srv/mediawiki/php-1.38.0-wmf.13/includes/user/UserOptionsManager.php(497): MediaWiki\User\UserOptionsManager->loadOriginalOptions(User, integer, NULL)
#5 /srv/mediawiki/php-1.38.0-wmf.13/includes/user/UserOptionsManager.php(147): MediaWiki\User\UserOptionsManager->loadUserOptions(User, integer)
#6 /srv/mediawiki/php-1.38.0-wmf.13/includes/user/User.php(2356): MediaWiki\User\UserOptionsManager->getOption(User, string, NULL, boolean)
#7 /srv/mediawiki/php-1.38.0-wmf.13/includes/context/RequestContext.php(384): User->getOption(string)
#8 /srv/mediawiki/php-1.38.0-wmf.13/extensions/GrowthExperiments/ServiceWiring.php(397): RequestContext->getLanguage()
#9 /srv/mediawiki/php-1.38.0-wmf.13/vendor/wikimedia/services/src/ServiceContainer.php(447): Wikimedia\Services\ServiceContainer::{closure}(MediaWiki\MediaWikiServices)
#10 /srv/mediawiki/php-1.38.0-wmf.13/vendor/wikimedia/services/src/ServiceContainer.php(416): Wikimedia\Services\ServiceContainer->createService(string)
#11 /srv/mediawiki/php-1.38.0-wmf.13/includes/MediaWikiServices.php(291): Wikimedia\Services\ServiceContainer->getService(string)
#12 /srv/mediawiki/php-1.38.0-wmf.13/vendor/wikimedia/services/src/ServiceContainer.php(424): MediaWiki\MediaWikiServices->getService(string)
#13 /srv/mediawiki/php-1.38.0-wmf.13/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php(209): Wikimedia\Services\ServiceContainer->get(string)
#14 /srv/mediawiki/php-1.38.0-wmf.13/vendor/wikimedia/object-factory/src/ObjectFactory/ObjectFactory.php(150): Wikimedia\ObjectFactory\ObjectFactory::getObjectFromSpec(array, array)
#15 /srv/mediawiki/php-1.38.0-wmf.13/includes/HookContainer/HookContainer.php(473): Wikimedia\ObjectFactory\ObjectFactory->createObject(array)
#16 /srv/mediawiki/php-1.38.0-wmf.13/includes/HookContainer/HookContainer.php(156): MediaWiki\HookContainer\HookContainer->getHandlers(string, array)
#17 /srv/mediawiki/php-1.38.0-wmf.13/includes/HookContainer/HookRunner.php(2366): MediaWiki\HookContainer\HookContainer->run(string, array)
#18 /srv/mediawiki/php-1.38.0-wmf.13/includes/auth/AuthManager.php(1828): MediaWiki\HookContainer\HookRunner->onLocalUserCreated(User, boolean)
#19 /srv/mediawiki/php-1.38.0-wmf.13/includes/Setup.php(900): MediaWiki\Auth\AuthManager->autoCreateUser(User, string, boolean)
#20 /srv/mediawiki/php-1.38.0-wmf.13/includes/WebStart.php(90): require_once(string)
#21 /srv/mediawiki/php-1.38.0-wmf.13/index.php(44): require(string)
#22 /srv/mediawiki/w/index.php(3): require(string)
#23 {main}

~100 times a day (example)

Details

SubjectRepoBranchLines +/-
Use content language for mentor intro textmediawiki/extensions/GrowthExperimentsmaster+6 -14
Customize query in gerrit

Related Objects
Search...

Event Timeline

Tgr created this task.Dec 16 2021, 3:41 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptDec 16 2021, 3:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Dec 16 2021, 3:42 AM
Tgr moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
Tgr added a parent task: T124367: User::loadFromSession called before the end of Setup.php.
Tgr added a comment.Dec 16 2021, 5:53 AM

This happens during registration. The control flow is MentorHooks::onLocalUserCreated hook called during autocreation -> MentorManager service gets instantiated (as a dependency of the hook) -> RequestContext::getMain()->getLanguage() is called as language is one of the parameters of the service constructor -> the usual dependency chain (language depends on preferences, preferences depend on user, user is still in the process of being autocreated).

In hindsight, using the same hook for normal registration and autocreation was not a good design decision.

gerritbot added a comment.Dec 16 2021, 6:48 AM

Change 747707 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] Use content language for mentor intro text

https://gerrit.wikimedia.org/r/747707

gerritbot added a project: Patch-For-Review.Dec 16 2021, 6:48 AM
Tgr claimed this task.Dec 16 2021, 6:54 AM
Tgr moved this task from Ready for Development to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 17 2021, 1:07 PM
gerritbot added a comment.Dec 17 2021, 1:29 PM

Change 747707 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Use content language for mentor intro text

https://gerrit.wikimedia.org/r/747707

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 17 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 17 2021, 2:10 PM
Urbanecm_WMF mentioned this in T298068: Exception: User::loadFromSession called before the end of Setup.php.Dec 21 2021, 10:32 AM
Urbanecm_WMF merged a task: T298068: Exception: User::loadFromSession called before the end of Setup.php.
Urbanecm_WMF added subscribers: Etonkovidova, Sgs, • mewoph and 2 others.
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 6 2022, 8:41 PM
Krinkle moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Jan 11 2022, 11:44 PM
Etonkovidova closed this task as Resolved.Jan 21 2022, 1:59 AM

No warnings are recorded after the patch was deployed to`wmf.14` - https://logstash.wikimedia.org/goto/24b06f9d4996ee261987ecdc511ce83d .

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits