Page MenuHomePhabricator
Create Task
Maniphest T297862

"shield-container" <div> added in every <ref>
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • use VisualEditor
  • user report: Version 96.0.4664.110 Google Chrome. I opened the visual editor and there I clicked on "Source", then I selected "Automatic", inserted an unformed link and clicked "Generate" and "Insert".

What happens?:

<div id="ssipdojbal" class="shield-container" style="cursor: pointer; display: -webkit-inline-box; width: 16px; height: 16px; min-width: 16px;"><div data-reactroot="" class="shield_container"><div class="wot_shield shield shield_gray "></div></div></div>

What should have happened instead?:

  • clean code without it

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Remove more DOM garbage introduced by 'Web of Trust' extensionmediawiki/extensions/VisualEditormaster+2 -1
Update Web of Trust junk workaroundmediawiki/extensions/VisualEditormaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Carn created this task.Dec 16 2021, 9:56 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2021, 9:56 AM
Maintenance_bot added a project: VisualEditor.Dec 16 2021, 10:45 AM
Carn updated the task description. (Show Details)Dec 16 2021, 12:51 PM
Radmir_Far subscribed.Dec 17 2021, 7:24 PM

I've reproduced the bug. See video demonstration: https://www.youtube.com/watch?v=SxXHP06_HIQ.

Radmir_Far added a comment.Dec 17 2021, 7:38 PM

It happens when you use the Web of Trust extension.

matmarex added a project: Editing-team (Kanban Board).Dec 19 2021, 11:28 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.

There was a previous issue with the same extension that was very similar: T189148: "donut-container" <div> added in every <ref>. Looks like the format of the junk the extension adds to pages has changed, and so our workaround that was supposed to remove it it no longer works. We can probably update it.

gerritbot added a comment.Dec 20 2021, 5:54 PM

Change 748769 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update Web of Trust junk workaround

https://gerrit.wikimedia.org/r/748769

gerritbot added a project: Patch-For-Review.Dec 20 2021, 5:54 PM

Change 748770 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Remove more DOM garbage introduced by 'Web of Trust' extension

https://gerrit.wikimedia.org/r/748770

matmarex claimed this task.Dec 20 2021, 5:54 PM
matmarex moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Dec 20 2021, 5:57 PM

Change 748769 abandoned by Bartosz Dziewoński:

[mediawiki/extensions/VisualEditor@master] Update Web of Trust junk workaround

Reason:

Looks like Ed has written the same patch at the same time, heh. I like his commit message more.

https://gerrit.wikimedia.org/r/748769

gerritbot added a comment.Dec 20 2021, 6:18 PM

Change 748770 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Remove more DOM garbage introduced by 'Web of Trust' extension

https://gerrit.wikimedia.org/r/748770

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 20 2021, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 20 2021, 7:10 PM
matmarex added a project: Skipped QA.Dec 20 2021, 7:53 PM
matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.
gerritbot added a comment.Dec 21 2021, 12:16 AM

Change 748842 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/Cite@master] Don't attach DOM nodes from the DM store to the main document

https://gerrit.wikimedia.org/r/748842

gerritbot added a project: Patch-For-Review.Dec 21 2021, 12:16 AM
matmarex mentioned this in T298147: Prevent browser extensions from inserting junk into the page HTML that gets saved.Dec 21 2021, 8:31 PM
matmarex removed a project: Patch-For-Review.Dec 21 2021, 8:33 PM

We might be able to prevent this in the future without maintaining a list of every extension that does this. I filed T298147 about the additional work and moved the new patch there.

ppelberg closed this task as Resolved.Dec 22 2021, 1:04 AM
Radmir_Far unsubscribed.Dec 22 2021, 5:59 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits