TagMultiselectWidget placeholder padding is sometimes to wide
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Dec 16 2021, 5:32 PM

Project Tags

Referenced Files

	F34909559: oojs-ui_670837 screencast 2022-01-06.mp4
	Jan 7 2022, 12:34 AM

	F34886679: image.png
	Dec 16 2021, 5:32 PM

	F34886675: image.png
	Dec 16 2021, 5:32 PM

	F34886682: image.png
	Dec 16 2021, 5:32 PM

	F34886677: image.png
	Dec 16 2021, 5:32 PM

Subscribers

Aklapper

Esanders

Volker_E

Description

The padding is not aligned with the widget in outline mode, or the TextInputWidget. In a form you would expect these to line up.

Empty:

With content:

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Update OOUI to v0.43.0	mediawiki/core	master	+824 -1 K
	TagMultiselectWidget: Fix margin & padding when empty	oojs/ui	master	+3 -1

Customize query in gerrit

Event Timeline

Esanders created this task.Dec 16 2021, 5:32 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 16 2021, 5:32 PM

Change 670837 had a related patch set uploaded (by Esanders; author: Esanders):

[oojs/ui@master] TagMultiselectWidget: Fix margin & padding when empty

https://gerrit.wikimedia.org/r/670837

gerritbot added a project: Patch-For-Review.Dec 16 2021, 5:32 PM

Volker_E triaged this task as Low priority.Jan 7 2022, 12:30 AM

Volker_E added a project: Design.

Change 670837 merged by jenkins-bot:

[oojs/ui@master] TagMultiselectWidget: Fix margin & padding when empty

https://gerrit.wikimedia.org/r/670837

What I've shared on the patch:

There was a thought behind this decision:
When you add an input and turn it into a tag, there should be no movement of the value when being transformed into a tag.
But I see your point about empty TagMultiselects underneath TextInputs. We've decided against those as TagMultiselect back then most often was a lone-standing component and not part of a long form.