Page MenuHomePhabricator

[WANObjectCache] ctype_digit(): Argument of type bool will be interpreted as string in the future
Closed, ResolvedPublicBUG REPORT

Description

Deprecated: ctype_digit(): Argument of type bool will be interpreted as string in the future in /code/w/includes/libs/objectcache/wancache/WANObjectCache.php on line 2598

Looks like that $mtime is called with a boolean occasionally, instead of an expected string.

Event Timeline

Krinkle renamed this task from ctype_digit(): Argument of type bool will be interpreted as string in the future to [WANObjectCache] ctype_digit(): Argument of type bool will be interpreted as string in the future.Dec 20 2021, 7:14 PM
Krinkle triaged this task as High priority.
Krinkle moved this task from General to libs/objectcache on the MediaWiki-libs-BagOStuff board.

Change 751817 had a related patch set uploaded (by Aaron Schulz; author: Aaron Schulz):

[mediawiki/core@master] objectcache: avoid use of ctype_digit() in WANObjectCache::adaptiveTTL()

https://gerrit.wikimedia.org/r/751817

Change 751817 merged by jenkins-bot:

[mediawiki/core@master] objectcache: avoid use of ctype_digit() in WANObjectCache::adaptiveTTL()

https://gerrit.wikimedia.org/r/751817

Change 932635 had a related patch set uploaded (by Reedy; author: Aaron Schulz):

[mediawiki/core@REL1_35] objectcache: avoid use of ctype_digit() in WANObjectCache::adaptiveTTL()

https://gerrit.wikimedia.org/r/932635

Change 932635 merged by jenkins-bot:

[mediawiki/core@REL1_35] objectcache: avoid use of ctype_digit() in WANObjectCache::adaptiveTTL()

https://gerrit.wikimedia.org/r/932635