Page MenuHomePhabricator

Add Proxy Information to infobox [L]
Closed, ResolvedPublic5 Estimated Story Points

Description

All ProxyType traits that return as true should be displayed in the infobox with newline separation. Possible values include:

  • Anonymous VPN
  • Hosting Provider
  • Public Proxy
  • Tor Exit Node
  • Residential Proxy
  • Legitimate Proxy

image.png (852×1 px, 128 KB)

AC

  • Proxy information is visible in the infobox
  • The label has a tooltip with the text "Proxies hide IP addresses. In some cases this happens automatically like for residential or corporate proxies, in other cases it's done intentionally to mask the origin of the IP address."

Details

Related Changes in Gerrit:

Event Timeline

Will there only ever be one of these values, or could it be a combination of these too?

I skimmed the csv and it can be a combination of many. One notably had four associated with it: is_anonymous,is_anonymous_vpn, is_hosting_provider, is_public_proxy

And following up from

Anonymous (what does this mean, aren't all IPs anonymous?)

is_anonymous appears to apply to every IP in the database so it doesn't seem like a good indicator of much.

I skimmed the csv and it can be a combination of many. One notably had four associated with it: is_anonymous,is_anonymous_vpn, is_hosting_provider, is_public_proxy

@cwylo @STran do these values logically make sense, as in can IPs be VPN, Hosting provider and a Public Proxy at the same time?

is_anonymous appears to apply to every IP in the database so it doesn't seem like a good indicator of much.

Just confirming if this is "all" or "almost all". Yeah, if its all, it isn't really helpful to share this.

do these values logically make sense, as in can IPs be VPN, Hosting provider and a Public Proxy at the same time?

I mean I would certainly never but you could make a server you own do whatever you want I suppose. I don't know if maxmind ever expires its data so it could be more accurate to say "This IP has been used for the following purposes before."

Just confirming if this is "all" or "almost all". Yeah, if its all, it isn't really helpful to share this.

My software will only load 1M rows (lol) but it's all 1M so presumably it's all of them.

STran renamed this task from Add Proxy Information to infobox to Add Proxy Information to infobox [L].Jan 18 2022, 7:59 PM
STran moved this task from Untriaged to The Letter Song on the Anti-Harassment-Team board.

I skimmed the csv and it can be a combination of many. One notably had four associated with it: is_anonymous,is_anonymous_vpn, is_hosting_provider, is_public_proxy

@cwylo @STran do these values logically make sense, as in can IPs be VPN, Hosting provider and a Public Proxy at the same time?

I believe it technically could but in our research the chances of all of these being true at the same time were low. For the purposes of flexibility or to cover edge cases it'd be good if we could cover a case in which this was true.

Change 759631 had a related patch set uploaded (by STran; author: STran):

[mediawiki/extensions/IPInfo@master] Add proxy types to infobox

https://gerrit.wikimedia.org/r/759631

ARamirez_WMF set the point value for this task to 5.Feb 8 2022, 5:00 PM

Change 759631 merged by jenkins-bot:

[mediawiki/extensions/IPInfo@master] Add proxy types to infobox

https://gerrit.wikimedia.org/r/759631

New Proxy Information to info box now showing
Value shows for proxy when true.

Screen Shot 2022-02-15 at 3.18.07 PM.png (1×2 px, 380 KB)

Screen Shot 2022-02-15 at 3.24.16 PM.png (1×2 px, 375 KB)

Screen Shot 2022-02-14 at 10.55.15 PM.png (1×2 px, 393 KB)