shellbox-pipeline-test jobs fail because they use php-ast 0.1.6
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Zabe
	Dec 19 2021, 12:39 PM

Description

https://gerrit.wikimedia.org/r/c/mediawiki/libs/Shellbox/+/748341 failed with the following error.

> phan --allow-polyfill-parser
ERROR: Phan 5.x requires php-ast 1.0.7+ because it depends on AST version 80. php-ast '0.1.6' is installed.

So I would consider upgrading php-ast?

Details

	Subject	Repo	Branch	Lines +/-
	build: Use composer-package-* images for running tests	mediawiki/libs/Shellbox	2.x	+3 -3
	build: Use composer-package-* images for running tests	mediawiki/libs/Shellbox	master	+3 -3

Customize query in gerrit

Event Timeline

Zabe created this task.Dec 19 2021, 12:39 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2021, 12:39 PM

I don't know precisely how that job works, but it seems to be using the composer-php72 image, on which we do NOT install our version of php-ast, so I guess it's just using some old version.

composer-package and phan jobs use our php-ast image, which comes with 1.0.14, so it's not quite like we need to upgrade it...

Daimona renamed this task from Upgrade to php-ast 1.0.7 in CI to shellbox-pipeline-test jobs fail because they use php-ast 0.1.6.Dec 20 2021, 1:09 PM

• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 21 2021, 12:02 AM

JJMC89 reopened this task as Open.Dec 21 2021, 12:17 AM

We can switch to the composer-package image I think.

Change 749140 had a related patch set uploaded (by Legoktm; author: Legoktm):

[mediawiki/libs/Shellbox@master] build: Use composer-package-* images for running tests

https://gerrit.wikimedia.org/r/749140

gerritbot added a project: Patch-For-Review.Dec 21 2021, 9:46 AM

Change 749140 merged by jenkins-bot:

[mediawiki/libs/Shellbox@master] build: Use composer-package-* images for running tests

https://gerrit.wikimedia.org/r/749140

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2021, 10:10 AM

Seems to be fixed now, thanks!

Change 808825 had a related patch set uploaded (by Reedy; author: Legoktm):

[mediawiki/libs/Shellbox@2.x] build: Use composer-package-* images for running tests

https://gerrit.wikimedia.org/r/808825

gerritbot added a project: Patch-For-Review.Jun 27 2022, 9:30 AM

Change 808825 merged by jenkins-bot: