Page MenuHomePhabricator
Create Task
Maniphest T298012

List type change is described once for each list item
Closed, ResolvedPublic
Actions

Description

  1. Open a doc that has a bullet list with multiple items
  2. Change that list to a numbered list
  3. View the visual diff

Expected:

  1. The change from bullet to numbered is described once

Actual:

  1. The change is described multiple times, once for each list item

Bonus: Hover on the change description should highlight the list and this is broken too.

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (4b2339f6e)mediawiki/extensions/VisualEditormaster+3 -1
List diff: Fix display of list node attribute change (e.g. bullet->numbered)VisualEditor/VisualEditormaster+60 -12
Customize query in gerrit

Event Timeline

Esanders created this task.Dec 19 2021, 3:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2021, 3:39 PM
gerritbot added a comment.Dec 20 2021, 2:16 PM

Change 748725 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] List diff: Fix display of list node attribute change (e.g. bullet->numbered)

https://gerrit.wikimedia.org/r/748725

gerritbot added a project: Patch-For-Review.Dec 20 2021, 2:16 PM
• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 21 2021, 12:02 AM
JJMC89 reopened this task as Open.Dec 21 2021, 12:17 AM
matmarex added a project: Editing-team (Kanban Board).Dec 21 2021, 7:20 PM
matmarex moved this task from To Triage to Triaged on the VisualEditor board.
gerritbot added a comment.Dec 21 2021, 7:23 PM

Change 748725 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] List diff: Fix display of list node attribute change (e.g. bullet->numbered)

https://gerrit.wikimedia.org/r/748725

gerritbot added a comment.Dec 21 2021, 7:25 PM

Change 749255 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b2339f6e)

https://gerrit.wikimedia.org/r/749255

gerritbot added a comment.Dec 21 2021, 7:51 PM

Change 749255 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (4b2339f6e)

https://gerrit.wikimedia.org/r/749255

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 21 2021, 8:00 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.Dec 21 2021, 8:00 PM
matmarex moved this task from Incoming to QA on the Editing-team (Kanban Board) board.
EAkinloose subscribed.Dec 22 2021, 4:44 PM

Change is described once and hovering over the change description highlights the list. See

Screenshot 2021-12-22 at 17.42.40.png (844×1 px, 151 KB)

EAkinloose edited projects, added Verified; removed Editing QA.Dec 22 2021, 4:45 PM
EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Esanders moved this task from Backlog to In progress on the VisualEditor-VisualDiffs board.Jan 19 2022, 1:40 AM
ppelberg closed this task as Resolved.Jan 21 2022, 4:22 AM
ppelberg claimed this task.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits