Page MenuHomePhabricator
Create Task
Maniphest T298030

Visual Editor hangs with Template:Graph:Lines
Closed, DeclinedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

Actually, I think you can just go directly to https://en.wikipedia.org/w/index.php?title=User:RoySmith/sandbox&oldid=1061181714&veaction=edit in one step.

What happens?:

You get a spinning progress indicator which never goes away

What should have happened instead?:

If Template:Graph is fundamentally incompatible with VE, put up some sort of "broken template" placeholder, or a message saying you need to use the source editor.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Chrome Version 96.0.4664.110 (Official Build) (x86_64)
MacOS Big Sur 11.6.1 (20G224)

Screen Shot 2021-12-20 at 8.47.06 AM.png (1×1 px, 171 KB)

Related Objects

Event Timeline

RoySmith created this task.Dec 20 2021, 1:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2021, 1:51 PM
Aklapper added a comment.Dec 20 2021, 2:39 PM

Hmm, what makes you think that something hangs somewhere? Should this maybe be named "VisualEditor shouldn't show an animated spinner for graphs"?

RoySmith added a comment.Dec 20 2021, 2:56 PM

I assumed the spinning wheel was a progress indicator, and the fact that it never stops spinning means something is failing to complete. If that's an incorrect assumption, I'm fine with renaming this. In any case, it should show some sort of placeholder giving the user appropriate feedback.

matmarex subscribed.EditedDec 20 2021, 5:41 PM

It's not actually loading anything, it's just a misleading interface.

Prior to T242855, the loading spinner was shown until the server-side generated graph was loaded. But now there are no server-side graphs, so it is just shown forever.

(Also note that this only affects graphs generated by templates; graphs using <graph> directly will render.)

• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 21 2021, 12:04 AM
MusikAnimal reopened this task as Open.Dec 21 2021, 12:17 AM
ppelberg added a project: Editing-team.Dec 22 2021, 4:40 PM
ppelberg moved this task from Untriaged to This Fiscal Year on the Editing-team board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
TheDJ claimed this task.Jan 20 2022, 10:48 AM
TheDJ added a project: User-TheDJ.
Iniquity moved this task from Backlog to VisualEditor on the MediaWiki-extensions-Graph board.Apr 7 2023, 12:59 PM
Jdlrobson triaged this task as Low priority.Apr 25 2023, 9:47 PM
Aklapper removed TheDJ as the assignee of this task.May 16 2024, 4:40 PM
Aklapper added a subscriber: TheDJ.

@TheDJ: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

TheDJ closed this task as Declined.May 16 2024, 6:12 PM

Considering the future of graphs, it is no longer relevant to work on this bug i think.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits