Page MenuHomePhabricator

Visual Editor hangs with Template:Graph:Lines
Closed, DeclinedPublicBUG REPORT

Description

List of steps to reproduce (step by step, including full links if applicable):

Actually, I think you can just go directly to https://en.wikipedia.org/w/index.php?title=User:RoySmith/sandbox&oldid=1061181714&veaction=edit in one step.

What happens?:

You get a spinning progress indicator which never goes away

What should have happened instead?:

If Template:Graph is fundamentally incompatible with VE, put up some sort of "broken template" placeholder, or a message saying you need to use the source editor.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Chrome Version 96.0.4664.110 (Official Build) (x86_64)
MacOS Big Sur 11.6.1 (20G224)

Screen Shot 2021-12-20 at 8.47.06 AM.png (1×1 px, 171 KB)

Related Objects

Event Timeline

Hmm, what makes you think that something hangs somewhere? Should this maybe be named "VisualEditor shouldn't show an animated spinner for graphs"?

I assumed the spinning wheel was a progress indicator, and the fact that it never stops spinning means something is failing to complete. If that's an incorrect assumption, I'm fine with renaming this. In any case, it should show some sort of placeholder giving the user appropriate feedback.

It's not actually loading anything, it's just a misleading interface.

Prior to T242855, the loading spinner was shown until the server-side generated graph was loaded. But now there are no server-side graphs, so it is just shown forever.

(Also note that this only affects graphs generated by templates; graphs using <graph> directly will render.)

ppelberg moved this task from Untriaged to This Fiscal Year on the Editing-team board.
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.
Aklapper added a subscriber: TheDJ.

@TheDJ: Removing task assignee as this open task has been assigned for more than two years - see the email sent to all task assignees on 2024-04-15.
Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be welcome! :)
If this task has been resolved in the meantime, or should not be worked on by anybody ("declined"), please update its task status via "Add Action… 🡒 Change Status".
Also see https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator. Thanks!

Considering the future of graphs, it is no longer relevant to work on this bug i think.