Page MenuHomePhabricator

Content from a template duplicated in a DiscussionTools edit (it.wikipedia)
Closed, ResolvedPublic

Description

Continuing from T290940, it seems like one of the cases there has not actually been fixed.

Recent examples: (in December, so long after the patches from that task were deployed)

Event Timeline

Upon closer inspection, this is the same issue as T289873#7524642 (the comments are partially template-generated but our code doesn't detect that), and the patch on that task should fix this too. I'll add another test case for it.

However, fixing the bug would make it impossible to reply to these comments. So I'll also propose some changes to the involved templates that should avoid that.

Change 749181 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Test case for several bugs from it.wp

https://gerrit.wikimedia.org/r/749181

Change 743524 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Improve detecting transcluded comments again

https://gerrit.wikimedia.org/r/743524

Change 749181 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Test case for several bugs from it.wp

https://gerrit.wikimedia.org/r/749181

Change 743524 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Improve detecting transcluded comments again

https://gerrit.wikimedia.org/r/743524

matmarex edited projects, added Skipped QA; removed Patch-For-Review.

In lieu of QA, we should just watch for similar dirty diffs in dtcheck and reopen this if they still occur.

matmarex moved this task from Ready for Sign Off to QA on the Editing-team (Kanban Board) board.

However, fixing the bug would make it impossible to reply to these comments. So I'll also propose some changes to the involved templates that should avoid that.

I almost forgot about this. Done now: https://it.wikipedia.org/w/index.php?title=Template:Vandalo&diff=125004528&oldid=122068717&diffmode=source

We should actually make sure that the [reply] buttons on https://it.wikipedia.org/wiki/Wikipedia:Vandalismi_in_corso still work after the changes are deployed.