Add a phan job to gated extensions/skins and core testing each change with all of them
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Jdforrester-WMF
	Dec 20 2021, 11:01 PM

Description

Right now we test PHPUnit, npm, and selenium tests from all gated extensions against all changes, but we don't do the same for phan, which means changes like https://gerrit.wikimedia.org/r/c/mediawiki/core/+/701074 can break the build for gated extensions.

We can fix this by adding (yet another) job running this change with all the other gated extensions together in the gate-and-submit branch, like we do with the 'wmf-quibble' jobs.

Event Timeline

Jdforrester-WMF created this task.Dec 20 2021, 11:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 20 2021, 11:01 PM

• BilalShirwani closed this task as a duplicate of T298058: [Impact Analysis] Evaluate Impact of Mobile Reply and New Discussion Tools.Dec 20 2021, 11:56 PM

JJMC89 reopened this task as Open.Dec 21 2021, 12:11 AM

I'm not sure if it's doable... The main potential issues I can think of are:

It might need A LOT of time and memory
We need to make sure that vendor dirs are only parsed once
Different repos have different configs
More code to analyze means that phan will end up analyzing some methods in a different order, which is going to have a noticeable effect on analysis result

And there's certainly more.

What would work is to loop over the gated extensions and, for each of them, run its phan job. This would be even slower and pretty lame, but at least it shouldn't suffer from the other issues.

Add a phan job to gated extensions/skins and core testing each change with all of themOpen, Needs TriagePublicActions

Description

Event Timeline

Add a phan job to gated extensions/skins and core testing each change with all of them
Open, Needs TriagePublic
Actions