Page MenuHomePhabricator

Comment highlights on a specific page on it.wp are all wrong
Closed, ResolvedPublic

Description

Comment highlights on https://it.wikipedia.org/wiki/Wikipedia:Vandalismi_in_corso are all wrong, because the comment start markers are in the wrong places.

For example, this link should highlight a single short comment, but it will actually cover half the screen: https://it.wikipedia.org/w/index.php?title=Wikipedia:Vandalismi_in_corso&oldid=124462482#c-Zoro1996-2021-12-02T10:54:00.000Z-2_dicembre

image.png (2×3 px, 478 KB)

Event Timeline

Change 749181 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Test case for several bugs from it.wp

https://gerrit.wikimedia.org/r/749181

Change 749182 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix inserting comment start markers when they're outside of any wrappers

https://gerrit.wikimedia.org/r/749182

(A little CSS snippet to reveal the markers for testing:)

span[data-mw-comment-start] {
    position: absolute;
    top: unset;
    outline: 5px solid red;
    display: inline-block;
}

span[data-mw-comment-end] {
    position: absolute;
    display: inline-block;
    outline: 5px solid blue;
}

Change 749181 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Test case for several bugs from it.wp

https://gerrit.wikimedia.org/r/749181

Change 749182 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix inserting comment start markers when they're outside of any wrappers

https://gerrit.wikimedia.org/r/749182