Page MenuHomePhabricator

Add an image: basic components (desktop)
Closed, ResolvedPublic

Description

For many parts of the desktop experience, we want to use the desktop versions of the elements already built for mobile. They will likely comply automatically to the desktop specifications. This task is meant to ensure that we double-check that all these elements will work fine on desktop and that we QA them.

These are the mobile tasks that should port over to desktop:

Figma: https://www.figma.com/file/ULhJr1isDstRbGE5vjYDsr/Add-images-structured-task?node-id=4029%3A51683

Event Timeline

These components are already in place from mobile, but some stylistic adjustments will be needed to align with the specs in Figma (for example, font sizes & line height since desktop and mobile specs have different scales)

No adjustments needed (these already have desktop variant since they are applicable to other task types)

  • Difficulty filter
  • Task type info
  • Suggestions mode
  • Overlay onboarding
  • Guidance content
  • Rejection dialog
  • Post-edit dialog
  • Minimal quality gate (daily limit)
  • Instrumentation

Stylistic adjustments needed

  • Save dialog
  • Image details

Missing functionality

  • Post-edit dialog upon rejection (currently there is a bug where it is not shown for add image)

Change 749794 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: update styles for desktop save and image details dialogs

https://gerrit.wikimedia.org/r/749794

Updated save dialog

Screen Shot 2021-12-23 at 1.34.20 PM.png (1×1 px, 208 KB)

Updated image details dialog

Screen Shot 2021-12-23 at 1.34.30 PM.png (664×1 px, 100 KB)

Change 749796 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: set madeNullEdit flag upon save

https://gerrit.wikimedia.org/r/749796

Change 749796 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: set madeNullEdit flag upon save

https://gerrit.wikimedia.org/r/749796

Change 749794 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: update styles for desktop save and image details dialogs

https://gerrit.wikimedia.org/r/749794

Reviewed the task - all phab tasks listed in the description have been marked as Resolved, so closing this task as Resolved too.

T292092: Add an image: overlay onboarding

For this task, it would be best if the "don't show again" selection would apply globally to desktop and mobile, in case the user does the task on both platforms. But if this is not trivial, then it is not required.

T292887: Add an image: captions onboarding dialog

For this task, it would be best if the "don't show again" selection would apply globally to desktop and mobile, in case the user does the task on both platforms. But if this is not trivial, then it is not required.

It's implemented - if a user selects "don't show again" on either mobile or desktop - the onboarding won't be shown again (unless a user resets all user preferences)