Page MenuHomePhabricator
Create Task
Maniphest T298111

Add an image: image inspector (desktop)
Closed, ResolvedPublic
Actions

Description

Corresponding task from mobile: T290045: Add an image: image inspector

The image inspector on desktop should have all the same functionality and layout as on mobile. The only difference is its location and size on the screen.

  • Just as the inspector is a sheet at the bottom of the screen on mobile, the desktop inspector should also be a sheet at the bottom of the screen on desktop, but with a width fixed at 480px.
  • Just as the inspector can be collapsed by tapping its header on mobile, the desktop inspector should collapse by clicking on its header.

Mockups as of 2021-12-21:

image.png (1×1 px, 1 MB)

NOTE: Refer to Figma for up-to-date detailed redline mocks and specs:
https://www.figma.com/file/ULhJr1isDstRbGE5vjYDsr/Add-images-structured-task?node-id=4029%3A101708

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add an image: desktop image inspectormediawiki/extensions/GrowthExperimentsmaster+50 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

MMiller_WMF created this task.Dec 21 2021, 4:56 PM
MMiller_WMF mentioned this in T298112: Add an image: image viewer (desktop).Dec 21 2021, 5:06 PM
MMiller_WMF triaged this task as High priority.Dec 21 2021, 5:59 PM
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph claimed this task.Dec 21 2021, 7:40 PM
• mewoph moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Dec 21 2021, 9:15 PM

Until the feature flags are in place, this can be tested by right clicking on the task card and open in new tab or copy the link address.

addimage_desktopInspector.gif (1×1 px, 1 MB)

kostajh added a comment.Jan 4 2022, 9:14 AM
In T298111#7584650, @mewoph wrote:

Until the feature flags are in place, this can be tested by right clicking on the task card and open in new tab or copy the link address.

addimage_desktopInspector.gif (1×1 px, 1 MB)

@mewoph I think there may be a patch missing from this task?

gerritbot added a comment.Jan 4 2022, 5:37 PM

Change 751476 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: desktop image inspector

https://gerrit.wikimedia.org/r/751476

gerritbot added a project: Patch-For-Review.Jan 4 2022, 5:37 PM
• mewoph added a comment.Jan 4 2022, 5:37 PM

Thanks @kostajh! I forgot to push the patch, it should be there now.

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 5 2022, 1:58 PM
In T298111#7596501, @mewoph wrote:

Thanks @kostajh! I forgot to push the patch, it should be there now.

👍🏻 thanks!

gerritbot added a comment.Jan 5 2022, 2:23 PM

Change 751476 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: desktop image inspector

https://gerrit.wikimedia.org/r/751476

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 5 2022, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 5 2022, 3:10 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 12 2022, 12:23 AM
Etonkovidova moved this task from Test in Production | Watching to Design Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 21 2022, 12:06 AM

For @RHo quick review - I did not see any issues; if there are no follow-ups needed, you may close it as Resolved.

RHo closed this task as Resolved.Jan 25 2022, 1:53 PM
In T298111#7638914, @Etonkovidova wrote:

For @RHo quick review - I did not see any issues; if there are no follow-ups needed, you may close it as Resolved.

Thanks @Etonkovidova - I filed a small visual design tweak at T300041 but this is fine to close.

Etonkovidova closed subtask T300041: Visual bug: collapse inspector chevron is too close to the RHS edge of the inspector frame as Resolved.Feb 4 2022, 7:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits