Page MenuHomePhabricator

Add an image: image viewer (desktop)
Closed, ResolvedPublic

Description

Corresponding task from mobile: T269644: Add a link: link inspector


When the user clicks anywhere on the image in the image inspector (T298111), they should get a "fullscreen" view. This is very similar to the mobile version.

  • It should not show image details, just the image alone.
  • The fullscreen image should have an "X" to close it in the upper right.
  • The browser back button should close the image viewer and take the user back to the task.

Spec details on Figma: https://www.figma.com/file/ULhJr1isDstRbGE5vjYDsr/Add-images-structured-task?node-id=4029%3A103506

Event Timeline

I'm moving this to QA since the functionality per the task description is already in place (until the feature flags are in place, this can be tested by right clicking on the task card and open in new tab or copy the link address).

Current image viewer:

addimage_desktopImageViewer.gif (1×1 px, 2 MB)

Checked in betalabs - works as expected.

@mewoph - a minor note: the vertical scrolling is present even for full-screen mode (but not for all images).
Couple of examples where the vertical scrolling is present:

full-screen view:

Screen Shot 2021-12-22 at 3.41.44 PM.png (1×3 px, 2 MB)

full-screen view:

Screen Shot 2021-12-22 at 3.36.30 PM.png (1×2 px, 760 KB)

Moving for @RHo review.

Change 753023 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Add an image: limit image height to prevent vertical scroll

https://gerrit.wikimedia.org/r/753023

@Etonkovidova I created a tentative patch to solve the vertical scroll issue. I couldn't test with the particular images that you posted, could you point me to an article that has this problem in beta?

Change 753023 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: limit image height to prevent vertical scroll

https://gerrit.wikimedia.org/r/753023

Etonkovidova claimed this task.

@Etonkovidova I created a tentative patch to solve the vertical scroll issue. I couldn't test with the particular images that you posted, could you point me to an article that has this problem in beta?

@Sgs - the patch seems to be working. I was looking at the images that have longer vertical length, and I didn't find any scrolling issues.

For example, this article (the filters are Biology + Add image) -
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Grant%27s_bluebill&gesuggestededit=1&veaction=edit - will not present the scrolling for the image in the full view (the image size is 305x365).