Page MenuHomePhabricator

Implementation page has several minor errors
Closed, InvalidPublic

Description

List of steps to reproduce (step by step, including full links if applicable):

  • I have a function with three implementations and two testers
  • I go to one of the implementations

What happens?:
The tester matrix shows all implementations and testers, not just the currently displayed implementation.

implementation before.png (1×2 px, 282 KB)

Now, when I select a value and call the function on the implementation, the tester matrix is re-run (why?), shows only the current implementation (good), but the results never come back. It still says Testers passing 6/6 (no, they are still running). Also the implementation is shown wrongly as not being attached to the function definition (before that it showed as attached).

implementation after.png (1×2 px, 301 KB)

What should have happened instead?:

  • Only the current implementation should be shown in the tester matrix
  • The testers should not be re-run on calling the function
  • the implementation should not be shown as detached after calling the function

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Event Timeline

Jdforrester-WMF changed the subtype of this task from "Bug Report" to "Task".Mar 7 2022, 2:39 PM
Jdforrester-WMF subscribed.

Not really a bug report.

Shall we move this to the next phase?

This is going to be worked or re-written with Aishwarya design work and investing time now may not be a very good use of time.

We can move this one to Phase Clean up. You are right that it is not in a hurry, and hopefully things will get fixed automatically on the way. But also note that we currently do not plan to have the implementation page redesigned before launch.

(But some of the fallout from the View function page might be helpful here)