Page MenuHomePhabricator
Create Task
Maniphest T298223

Global suppressions throw 'Deprecated cross-wiki access' warnings
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

(context: my two wikis are called 'wikidb' and 'meta', the suppression has been performed on 'wikidb')

Deprecated cross-wiki access to MediaWiki\User\UserIdentityValue. Expected: the local wiki, Actual: 'meta'. Pass expected $wikiId. [Called from MediaWiki\User\UserIdentityValue::getId in /var/www/html/core/includes/user/UserIdentityValue.php at line 144]
Backtrace:

    WikiAwareEntityTrait.php line 75 calls wfDeprecatedMsg()
    UserIdentityValue.php line 144 calls MediaWiki\User\UserIdentityValue->deprecateInvalidCrossWiki()
    DatabaseBlockStore.php line 391 calls MediaWiki\User\UserIdentityValue->getId()
    DatabaseBlockStore.php line 202 calls MediaWiki\Block\DatabaseBlockStore->getArrayForDatabaseBlock()
    DatabaseBlock.php line 500 calls MediaWiki\Block\DatabaseBlockStore->insertBlock()
    CentralAuthUser.php line 1950 calls MediaWiki\Block\DatabaseBlock->insert()
    CentralAuthUser.php line 1876 calls CentralAuthUser->doLocalSuppression()
    CentralAuthUser.php line 1854 calls CentralAuthUser->doCrosswikiSuppression()
    CentralAuthUser.php line 1816 calls CentralAuthUser->suppress()
    SpecialCentralAuth.php line 294 calls CentralAuthUser->adminLockHide()
    SpecialCentralAuth.php line 194 calls MediaWiki\Extension\CentralAuth\Special\SpecialCentralAuth->doSubmit()
    SpecialPage.php line 671 calls MediaWiki\Extension\CentralAuth\Special\SpecialCentralAuth->execute()
    SpecialPageFactory.php line 1378 calls SpecialPage->run()
    MediaWiki.php line 314 calls MediaWiki\SpecialPage\SpecialPageFactory->executePath()
    MediaWiki.php line 903 calls MediaWiki->performRequest()
    MediaWiki.php line 563 calls MediaWiki->main()
    index.php line 53 calls MediaWiki->run()
    index.php line 46 calls wfIndexMain()
Deprecated cross-wiki access to MediaWiki\User\UserIdentityValue. Expected: the local wiki, Actual: 'wikidb'. Pass expected $wikiId. [Called from MediaWiki\User\UserIdentityValue::getId in /var/www/html/core/includes/user/UserIdentityValue.php at line 144]
Backtrace:

    WikiAwareEntityTrait.php line 75 calls wfDeprecatedMsg()
    UserIdentityValue.php line 144 calls MediaWiki\User\UserIdentityValue->deprecateInvalidCrossWiki()
    DatabaseBlockStore.php line 391 calls MediaWiki\User\UserIdentityValue->getId()
    DatabaseBlockStore.php line 202 calls MediaWiki\Block\DatabaseBlockStore->getArrayForDatabaseBlock()
    DatabaseBlock.php line 500 calls MediaWiki\Block\DatabaseBlockStore->insertBlock()
    CentralAuthUser.php line 1950 calls MediaWiki\Block\DatabaseBlock->insert()
    CentralAuthUser.php line 1876 calls CentralAuthUser->doLocalSuppression()
    CentralAuthUser.php line 1854 calls CentralAuthUser->doCrosswikiSuppression()
    CentralAuthUser.php line 1816 calls CentralAuthUser->suppress()
    SpecialCentralAuth.php line 294 calls CentralAuthUser->adminLockHide()
    SpecialCentralAuth.php line 194 calls MediaWiki\Extension\CentralAuth\Special\SpecialCentralAuth->doSubmit()
    SpecialPage.php line 671 calls MediaWiki\Extension\CentralAuth\Special\SpecialCentralAuth->execute()
    SpecialPageFactory.php line 1378 calls SpecialPage->run()
    MediaWiki.php line 314 calls MediaWiki\SpecialPage\SpecialPageFactory->executePath()
    MediaWiki.php line 903 calls MediaWiki->performRequest()
    MediaWiki.php line 563 calls MediaWiki->main()
    index.php line 53 calls MediaWiki->run()
    index.php line 46 calls wfIndexMain()
Deprecated passing invalid cross-wiki user. Expected: 'wikidb', Actual: the local wiki. [Called from MediaWiki\User\ActorStore::validateActorForInsertion in /var/www/html/core/includes/user/ActorStore.php at line 618]
Backtrace:

    ActorStore.php line 740 calls wfDeprecatedMsg()
    ActorStore.php line 618 calls MediaWiki\User\ActorStore->deprecateInvalidCrossWikiParam()
    ActorStore.php line 401 calls MediaWiki\User\ActorStore->validateActorForInsertion()
    DatabaseBlockStore.php line 401 calls MediaWiki\User\ActorStore->acquireActorId()
    DatabaseBlockStore.php line 202 calls MediaWiki\Block\DatabaseBlockStore->getArrayForDatabaseBlock()
    DatabaseBlock.php line 500 calls MediaWiki\Block\DatabaseBlockStore->insertBlock()
    CentralAuthUser.php line 1950 calls MediaWiki\Block\DatabaseBlock->insert()
    CentralAuthUser.php line 1876 calls CentralAuthUser->doLocalSuppression()
    CentralAuthUser.php line 1854 calls CentralAuthUser->doCrosswikiSuppression()
    CentralAuthUser.php line 1816 calls CentralAuthUser->suppress()
    SpecialCentralAuth.php line 294 calls CentralAuthUser->adminLockHide()
    SpecialCentralAuth.php line 194 calls MediaWiki\Extension\CentralAuth\Special\SpecialCentralAuth->doSubmit()
    SpecialPage.php line 671 calls MediaWiki\Extension\CentralAuth\Special\SpecialCentralAuth->execute()
    SpecialPageFactory.php line 1378 calls SpecialPage->run()
    MediaWiki.php line 314 calls MediaWiki\SpecialPage\SpecialPageFactory->executePath()
    MediaWiki.php line 903 calls MediaWiki->performRequest()
    MediaWiki.php line 563 calls MediaWiki->main()
    index.php line 53 calls MediaWiki->run()
    index.php line 46 calls wfIndexMain()

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
CentralAuthUser: use WikiAwareEntity::LOCAL for local wiki suppressionmediawiki/extensions/CentralAuthmaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

Zabe created this task.Dec 23 2021, 1:14 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2021, 1:14 AM
Zabe added a project: Wikimedia-production-error.Dec 23 2021, 1:15 AM
Zabe changed the subtype of this task from "Task" to "Production Error".

Actually these also show up in production: c2a4eb8a-85fc-4d8c-b624-bcda1f6637bd

Zabe added a comment.EditedDec 23 2021, 1:49 AM

I think the proper fix of this is just T274817: Convert DatabaseBlock and AbstractBlock to UserIdentity, and make them cross-wiki aware. (as part of T291994: Properly support cross-wiki blocking).

Zabe added a project: Platform Engineering.Dec 23 2021, 11:30 AM
thcipriani moved this task from Untriaged to Dec 2021 on the Wikimedia-production-error board.Jan 6 2022, 4:54 PM
daniel subscribed.Jan 20 2022, 10:45 AM

The next step here would be to make DatabaseBlockStore wiki-ware. It already kind of is, so this should be easy enough.
This would be a good opportunity to move DB layer code out of DatabaseBlock and BlockUser into DatabaseBlockStore.

daniel triaged this task as Medium priority.Jan 20 2022, 10:45 AM
Zabe added a comment.Jan 20 2022, 10:50 AM
In T298223#7635876, @daniel wrote:

The next step here would be to make DatabaseBlockStore wiki-ware.

I actually created T291849 for this some time ago.

Zabe mentioned this in T298784: Security Issue Access Request for Zabe.Jan 20 2022, 2:20 PM
gerritbot added a comment.Jan 27 2022, 4:43 PM

Change 756137 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CentralAuth@master] CentralAuthUser: use WikiAwareEntity::LOCAL for local wiki suppression

https://gerrit.wikimedia.org/r/756137

gerritbot added a project: Patch-For-Review.Jan 27 2022, 4:43 PM
Zabe added a comment.Jan 27 2022, 4:50 PM

There are three deprecation warnings. One has been fixed by https://gerrit.wikimedia.org/r/c/723790. The other two should be fixed by the patch above. One of those two has also been reported at T287625.

gerritbot added a comment.Jan 31 2022, 9:24 PM

Change 756137 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] CentralAuthUser: use WikiAwareEntity::LOCAL for local wiki suppression

https://gerrit.wikimedia.org/r/756137

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 31 2022, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 31 2022, 10:10 PM
Zabe closed this task as Resolved.EditedFeb 2 2022, 2:47 PM
Zabe claimed this task.

I am no longer getting deprecation warnings locally, should be fixed in wmf.20 on production.

Zabe mentioned this in T260933: Make UserIdentity objects aware of which wiki they belong to.Apr 20 2022, 10:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits