TypeError shown when attempting to dismiss New Discussion Tool Hint
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ppelberg
	Dec 23 2021, 2:01 AM

Description

This task is about resolving the error that appears when attempting to dismiss the hint within the New Discussion Tool (T293962) by way of clicking X in the hint's top right corner.

Thank you to the @TheDJ who reported this in Topic:Wmp1zmbzcyd1adxj.

Behavior

Log in to https://patchdemo.wmflabs.org/wikis/f2fc988871
Visit a talk page. E.g. https://patchdemo.wmflabs.org/wikis/f2fc988871/wiki/Talk:The_Hitchhiker%27s_Guide_to_the_Galaxy .
Click Add topic
Verify the hint (T293962) appears above the New Discussion Tool
Click the X that appears in the top right corner of the hint

Actual

❗️Nothing happens (open the console and see an error that begins with Uncaught TypeError: this.toggle is not a function appears)

Expected

✅The hint disappears

Done

Expected behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Fix closing the new topic tool hint	mediawiki/extensions/DiscussionTools	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: T293962: Introduce a "hint" that informs people how they can enable the legacy section=new experience

Event Timeline

ppelberg created this task.Dec 23 2021, 2:01 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 23 2021, 2:01 AM

ppelberg moved this task from Incoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Dec 23 2021, 2:01 AM

Raising priority so that volunteers can, ideally, experiment with the New Discussion Tool prototype [i] while Foundation Staff are out on holiday break.

i. https://www.mediawiki.org/wiki/Topic:Wmkj01bhaql86bod

matmarex renamed this task from TyperError shown when attempting to dismiss New Discussion Tool Hint to TypeError shown when attempting to dismiss New Discussion Tool Hint.Dec 23 2021, 6:56 PM

matmarex claimed this task.

It's a silly thing to miss, we've moved the code that closes the hint late in development and I guess we didn't re-test it after that change (or notice that it refers to variables in a different scope).

I added a local hack on the demo wiki, so that we won't have to re-make it: https://patchdemo.wmflabs.org/wikis/f2fc988871/wiki/MediaWiki:Common.js

Change 749764 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Fix closing the new topic tool hint

https://gerrit.wikimedia.org/r/749764

gerritbot added a project: Patch-For-Review.Dec 23 2021, 7:01 PM

matmarex moved this task from Ready to Be Worked On to Code Review on the Editing-team (Kanban Board) board.Dec 23 2021, 7:01 PM

In T298224#7587947, @matmarex wrote:

I added a local hack on the demo wiki, so that we won't have to re-make it: https://patchdemo.wmflabs.org/wikis/f2fc988871/wiki/MediaWiki:Common.js

Excellent, @matmarex – this looks to be working as expected now.

Change 749764 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Fix closing the new topic tool hint

https://gerrit.wikimedia.org/r/749764

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.16; 2022-01-03).Dec 29 2021, 5:00 PM

Maintenance_bot removed a project: Patch-For-Review.Dec 29 2021, 5:10 PM

matmarex moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Dec 30 2021, 4:25 PM

matmarex added a project: Editing QA.

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jan 10 2022, 5:13 AM

The hint disappears as expected. See https://photos.app.goo.gl/MfMWaMLRBis1KhU89

@EAkinloose (In response to the question you asked in the meeting) The legacy hint isn't intended to have the dismiss button, according to T293962#7576903. Does the reasoning there make sense to you?

It does now. Thanks for clarifying @matmarex .

EAkinloose edited projects, added Verified; removed Editing QA.Jan 13 2022, 8:33 PM

EAkinloose moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 13 2022, 8:41 PM

ppelberg closed this task as Resolved.Jan 19 2022, 1:03 AM

TypeError shown when attempting to dismiss New Discussion Tool HintClosed, ResolvedPublicActions