Page MenuHomePhabricator
Create Task
Maniphest T298300

Globally set preferences not greyed out in local preferences in "Beta features" section
Closed, ResolvedPublicBUG REPORT
Actions

Description

(Moved from T286271: Globally set preferences no longer greyed out in local preferences)

In Chinese Wikipedia, globally set preferences are not greyed out in local preferences in the Beta features section.

Quote from @Func :

As I can see, that's because NewHTMLCheckField is not infusible, and contains no 'disable-if' information.

Screenshot 2021-12-24 181158.png (1,310×924 px, 110 KB)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use native method to disable checkboxes when "enable most features" is selectedmediawiki/extensions/BetaFeaturesmaster+10 -16
Support disable-if param to be set for NewHTMLCheckFieldmediawiki/extensions/BetaFeaturesmaster+10 -3
Customize query in gerrit

Related Objects

Event Timeline

MilkyDefer created this task.Dec 24 2021, 11:58 AM
Restricted Application added a project: Community-Tech. · View Herald TranscriptDec 24 2021, 11:58 AM
Restricted Application added subscribers: Stang, Aklapper. · View Herald Transcript
Func added a project: BetaFeatures.Dec 24 2021, 12:00 PM
gerritbot added a comment.Dec 24 2021, 2:12 PM

Change 749774 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/BetaFeatures@master] Support disable-if param to be set for NewHTMLCheckField

https://gerrit.wikimedia.org/r/749774

gerritbot added a project: Patch-For-Review.Dec 24 2021, 2:12 PM
Func removed a project: MediaWiki-extensions-GlobalPreferences.Dec 24 2021, 2:41 PM
gerritbot added a comment.Dec 24 2021, 2:47 PM

Change 749775 had a related patch set uploaded (by Func; author: Func):

[mediawiki/extensions/BetaFeatures@master] Use native method to disable checkboxes when \"enable most features\" is selected

https://gerrit.wikimedia.org/r/749775

Func mentioned this in T292454: If you automatically enable all Beta Features locally, then you can't enable any of them in Global Preferences.Dec 24 2021, 3:37 PM
matmarex merged a task: T298680: Beta features checkboxes are enabled even with local exception off.Jan 6 2022, 8:05 PM
matmarex added subscribers: dom_walden, matmarex.
gerritbot added a comment.Jan 12 2022, 4:18 PM

Change 749774 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Support disable-if param to be set for NewHTMLCheckField

https://gerrit.wikimedia.org/r/749774

gerritbot added a comment.Jan 12 2022, 4:18 PM

Change 749775 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Use native method to disable checkboxes when \"enable most features\" is selected

https://gerrit.wikimedia.org/r/749775

matmarex closed this task as Resolved.Jan 12 2022, 4:19 PM
matmarex assigned this task to Func.

Thank you!

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.18; 2022-01-17).Jan 12 2022, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 12 2022, 5:10 PM
Stang unsubscribed.Jan 12 2022, 9:56 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits