Page MenuHomePhabricator

The database column page.page_links_updated should not tagged to allow infinite
Closed, ResolvedPublic

Description

The abstract schema at tables.json contains:

		"name": "page",
		"comment": "Core of the wiki: each page has an entry here which identifies it by title and contains some essential metadata.",
		"columns": [
...
			{
				"name": "page_links_updated",
				"comment": "This timestamp is updated whenever a page is re-parsed and it has all the link tracking tables updated for it. This is useful for de-duplicating expensive backlink update jobs.",
				"type": "mwtimestamp",
				"options": {
					"notnull": false,
					"default": null,
					"CustomSchemaOptions": {
						"allowInfinite": true
					}
				}
			},
...

In my opinion there is not need for the page_links_updated column to allow the value infinite.
The nullable and default value is okay.

This only affect mysql, where a VARBINARY(14) is used, which could be changed to BINARY(14)

abstract schema migration: 6a3aa5b5a2c91c07be669dc915cb4ba38a5a8692

Details

Event Timeline

Change #1057953 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] schema: Remove allowInfinite from page_links_updated

https://gerrit.wikimedia.org/r/1057953

Change #1057953 merged by jenkins-bot:

[mediawiki/core@master] schema: Remove allowInfinite from page_links_updated

https://gerrit.wikimedia.org/r/1057953