List of steps to reproduce (step by step, including full links if applicable):
- Allow only login by external account (no local account). Make sure your account is not created yet on your wiki.
- Try to make first login
- See error message
Message wsoauth-user-already-exists-message is displayed, account is not created or logged. It informs my username is already used on wiki but no local account or previous login tries before.
What should have happened instead?:
I should be logged in.
This change: https://github.com/wikimedia/mediawiki-extensions-WSOAuth/commit/852683a8e2e005cac5751c4bdfc75df76c8c5909#diff-df6a7ea90992f626a6690270b956967af397eb5046988cb782a49279470a92a0
In the new version of the file there is no exception in the condition for "guest" user, as in previous version on line https://github.com/wikimedia/mediawiki-extensions-WSOAuth/blob/51475be460dee8da0f9ebf31c6eb32b54d84b7e6/src/WSOAuth.php#L115 but from line 131 of new version code from line 146 is applied to anonymous user who of course may not have account.