Page MenuHomePhabricator

Requesting logo change for zh.wikinews.org
Closed, ResolvedPublic

Description

Event Timeline

Change 751530 had a related patch set uploaded (by Juan90264; author: Juan90264):

[operations/mediawiki-config@master] Change the Traditional Chinese and Simplified Chinese logo for zhwikinews

https://gerrit.wikimedia.org/r/751530

Change 751530 merged by jenkins-bot:

[operations/mediawiki-config@master] Change the Traditional Chinese and Simplified Chinese logo for zhwikinews

https://gerrit.wikimedia.org/r/751530

Mentioned in SAL (#wikimedia-operations) [2022-01-06T00:29:34Z] <dancy@deploy1002> Synchronized static/images/project-logos: Config: [[gerrit:751530|Change the Traditional Chinese and Simplified Chinese logo for zhwikinews (T298550)]] (duration: 01m 17s)

Mentioned in SAL (#wikimedia-operations) [2022-01-06T00:30:56Z] <dancy@deploy1002> Synchronized logos/config.yaml: Config: [[gerrit:751530|Change the Traditional Chinese and Simplified Chinese logo for zhwikinews (T298550)]] (duration: 01m 07s)

Mentioned in SAL (#wikimedia-operations) [2022-01-06T00:32:14Z] <dancy@deploy1002> Synchronized wmf-config/logos.php: Config: [[gerrit:751530|Change the Traditional Chinese and Simplified Chinese logo for zhwikinews (T298550)]] (duration: 01m 07s)

@Ericliu1912: Okay... The logo in zh has already been changed and is working, but the logo zh-hans has been added and you will need to have in [[MediaWiki:Common.css]] (https://zh.wikinews.org/wiki/MediaWiki:Common.css), the code below to work:

/* Change logo for zh-hans variants, per [[Phabricator:T298550]] */

.mw-wiki-logo:not(.timeless-logo):lang(zh-hans),
.mw-wiki-logo:not(.timeless-logo):lang(zh-cn),
.mw-wiki-logo:not(.timeless-logo):lang(zh-my),
.mw-wiki-logo:not(.timeless-logo):lang(zh-sg) {
    background-image: url(/static/images/project-logos/zhwikinews-hans.png);
}

@media (-webkit-min-device-pixel-ratio: 1.5), (min--moz-device-pixel-ratio: 1.5), (min-resolution: 1.5dppx), (min-resolution: 144dpi) {
    .mw-wiki-logo:not(.timeless-logo):lang(zh-hans),
    .mw-wiki-logo:not(.timeless-logo):lang(zh-cn),
    .mw-wiki-logo:not(.timeless-logo):lang(zh-my),
    .mw-wiki-logo:not(.timeless-logo):lang(zh-sg) {
        background-image: url(/static/images/project-logos/zhwikinews-hans-1.5x.png);
        background-size: 135px auto;
    }
}
@media (-webkit-min-device-pixel-ratio: 2), (min--moz-device-pixel-ratio: 2), (min-resolution: 2dppx), (min-resolution: 192dpi) {
    .mw-wiki-logo:not(.timeless-logo):lang(zh-hans),
    .mw-wiki-logo:not(.timeless-logo):lang(zh-cn),
    .mw-wiki-logo:not(.timeless-logo):lang(zh-my),
    .mw-wiki-logo:not(.timeless-logo):lang(zh-sg) {
        background-image: url(/static/images/project-logos/zhwikinews-hans-2x.png);
    }
}

I've notified an administrator locally about the CSS issue. But was the deployment really successful? Currently there seems to be no visible change whatsoever.

I've notified an administrator locally about the CSS issue. But was the deployment really successful? Currently there seems to be no visible change whatsoever.

Yes, the deployment was successful. The 1x logo (which is normally visible) there were no physical changes compared to the old one, only the size, but if you zoom your browser by 150% you will see that the 1.5x logo has indeed changed compared to the old one and the 2x logo (Which can be seen using the 200%) zoom compared to the old one had a noticeable difference in colors.

Now the logo in zh-hans is already on the server, but it needs the code to work.

Currently it is still not consistent. In fact through the method you provide, it is very clear that the picture change halfway through zooming (just like before), which should not happen since each sizes of the logo should had already be updated to be the same picture per the Gerrit patch. Purging the page didn't make a difference. (By the way I use zh-tw)

I've notified an administrator locally about the CSS issue. But was the deployment really successful? Currently there seems to be no visible change whatsoever.

As the local Interface Editor, I have updated the common.css accordingly.
https://zh.wikinews.org/w/index.php?diff=208602

Please confirm if it works well, thanks.

Currently it is still not consistent. In fact through the method you provide, it is very clear that the picture change halfway through zooming (just like before), which should not happen since each sizes of the logo should had already be updated to be the same picture per the Gerrit patch. Purging the page didn't make a difference. (By the way I use zh-tw)

Hi Ericliu1912, I asked you to purge the change and you've already done it, can you let me know if you can see the proposed logo now? If you can't see it, be aware that files in /static usually take weeks to take effect everywhere, before any and all browser caches expire.

I've notified an administrator locally about the CSS issue. But was the deployment really successful? Currently there seems to be no visible change whatsoever.

As the local Interface Editor, I have updated the common.css accordingly.
https://zh.wikinews.org/w/index.php?diff=208602

Please confirm if it works well, thanks.

Thanks for putting the code in, this code allows the zh-hans logo to work (I ran a test to see if the zh-hans logo appears by changing my language temporarily and it did)

Currently it is still not consistent. In fact through the method you provide, it is very clear that the picture change halfway through zooming (just like before), which should not happen since each sizes of the logo should had already be updated to be the same picture per the Gerrit patch. Purging the page didn't make a difference. (By the way I use zh-tw)

Hi Ericliu1912, I asked you to purge the change and you've already done it, can you let me know if you can see the proposed logo now? If you can't see it, be aware that files in /static usually take weeks to take effect everywhere, before any and all browser caches expire.

I used a different browser, and it did work. I apologize for my impatience, as though I understand how cache works, I still can't help worrying about it not working. Thanks for claiming the task!

Juan90264 closed this task as Resolved.EditedJan 7 2022, 9:56 PM
Juan90264 moved this task from Working on to Resolved on the User-Juan90264 board.

Currently it is still not consistent. In fact through the method you provide, it is very clear that the picture change halfway through zooming (just like before), which should not happen since each sizes of the logo should had already be updated to be the same picture per the Gerrit patch. Purging the page didn't make a difference. (By the way I use zh-tw)

Hi Ericliu1912, I asked you to purge the change and you've already done it, can you let me know if you can see the proposed logo now? If you can't see it, be aware that files in /static usually take weeks to take effect everywhere, before any and all browser caches expire.

I used a different browser, and it did work. I apologize for my impatience, as though I understand how cache works, I still can't help worrying about it not working. Thanks for claiming the task!

All right, I assume the task is done.