Page MenuHomePhabricator
Create Task
Maniphest T298552

Add an image: rejection doesn't work on desktop
Closed, ResolvedPublicBUG REPORT
Actions

Description

List of steps to reproduce (step by step, including full links if applicable):

  • Go to Special:Homepage
  • Enable add image on desktop (by running ge.utils.enableAddImageDesktop() console snippet)
  • Click on add image task
  • Reject the suggestion

What happens?:
Nothing happens, the following console warning is shown

load.php?lang=en&modules=ext.cite.ux-enhancements|ext.growthExperiments.Help%2CHelpPanel|ext.growthExperiments.StructuredTask.PreEdit|jquery%2Coojs-ui-core%2Coojs-ui-widgets|mediawiki.pulsatingdot|oojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:188 jQuery.Deferred exception: Cannot read properties of null (reading 'reset') TypeError: Cannot read properties of null (reading 'reset')
    at AddImageDesktopArticleTarget.ve.init.mw.DesktopArticleTarget.saveComplete (http://localhost:8080/w/load.php?lang=en&modules=ext.visualEditor.articleTarget%2Cbase%2Ccore%2CdesktopArticleTarget%2CdesktopTarget%2Cdiffing%2Cicons%2Clanguage%2Cmediawiki%2Cmwalienextension%2Cmwcore%2Cmwextensions%2Cmwformatting%2Cmwgallery%2Cmwimage%2Cmwlanguage%2Cmwlink%2Cmwmeta%2Cmwsave%2Cmwsignature%2Cmwtransclusion%2Csanitize%2Cswitching%2Cwelcome%7Cext.visualEditor.core.desktop%2Cutils%7Cext.visualEditor.mwextensions.desktop%7Cext.visualEditor.mwimage.core&skin=vector&version=1laq9:946:810)
    at fire (http://localhost:8080/w/load.php?lang=en&modules=ext.cite.ux-enhancements%7Cext.growthExperiments.Help%2CHelpPanel%7Cext.growthExperiments.StructuredTask.PreEdit%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.pulsatingdot%7Coojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:182:934)
    at fireWith (http://localhost:8080/w/load.php?lang=en&modules=ext.cite.ux-enhancements%7Cext.growthExperiments.Help%2CHelpPanel%7Cext.growthExperiments.StructuredTask.PreEdit%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.pulsatingdot%7Coojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:184:135)
    at mightThrow (http://localhost:8080/w/load.php?lang=en&modules=ext.cite.ux-enhancements%7Cext.growthExperiments.Help%2CHelpPanel%7Cext.growthExperiments.StructuredTask.PreEdit%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.pulsatingdot%7Coojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:186:487)
    at process (http://localhost:8080/w/load.php?lang=en&modules=ext.cite.ux-enhancements%7Cext.growthExperiments.Help%2CHelpPanel%7Cext.growthExperiments.StructuredTask.PreEdit%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.pulsatingdot%7Coojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:186:544)
    at http://localhost:8080/w/load.php?lang=en&modules=ext.cite.ux-enhancements%7Cext.growthExperiments.Help%2CHelpPanel%7Cext.growthExperiments.StructuredTask.PreEdit%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.pulsatingdot%7Coojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:186:768
    at mightThrow (http://localhost:8080/w/load.php?lang=en&modules=ext.cite.ux-enhancements%7Cext.growthExperiments.Help%2CHelpPanel%7Cext.growthExperiments.StructuredTask.PreEdit%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.pulsatingdot%7Coojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:185:881)
    at process (http://localhost:8080/w/load.php?lang=en&modules=ext.cite.ux-enhancements%7Cext.growthExperiments.Help%2CHelpPanel%7Cext.growthExperiments.StructuredTask.PreEdit%7Cjquery%2Coojs-ui-core%2Coojs-ui-widgets%7Cmediawiki.pulsatingdot%7Coojs-ui.styles.icons-alerts%2Cicons-editing-advanced%2Cicons-editing-citation%2Cicons-editing-core%2Cicons-interactions%2Cicons-movement%2Cicons-user&skin=vector&version=u6a5x:186:544) undefined

What should have happened instead?:
A progress bar should be shown while the article is being saved (per T295929#7562499). When the save is done, the post-edit dialog should be shown.

Software version (if not a Wikimedia wiki), browser information, screenshots, other information, etc:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add an image: save the article without showing the save dialog on desktopmediawiki/extensions/GrowthExperimentsmaster+92 -13
Check for saveDialog in ve.init.mw.DesktopArticleTarget.saveCompletemediawiki/extensions/VisualEditormaster+4 -1
Customize query in gerrit

Related Objects
Search...

Event Timeline

• mewoph created this task.Jan 4 2022, 7:10 PM
• mewoph claimed this task.
• mewoph moved this task from Incoming to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.
• mewoph added a comment.Jan 4 2022, 7:59 PM

This is due to T295929: Add an image: After rejecting an image, the user should be taken directly to the post-edit dialog — the changes were only implemented on mobile.

gerritbot added a comment.Jan 4 2022, 9:33 PM

Change 751496 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/VisualEditor@master] Check for saveDialog in ve.init.mw.DesktopArticleTarget.saveComplete

https://gerrit.wikimedia.org/r/751496

gerritbot added a project: Patch-For-Review.Jan 4 2022, 9:33 PM
gerritbot added a comment.Jan 4 2022, 11:06 PM

Change 751515 had a related patch set uploaded (by MewOphaswongse; author: MewOphaswongse):

[mediawiki/extensions/GrowthExperiments@master] Add an image: save the article without showing the save dialog on deskto

https://gerrit.wikimedia.org/r/751515

• mewoph updated the task description. (Show Details)Jan 4 2022, 11:08 PM
• mewoph moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Jan 5 2022, 5:23 PM

Change 751496 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Check for saveDialog in ve.init.mw.DesktopArticleTarget.saveComplete

https://gerrit.wikimedia.org/r/751496

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 5 2022, 6:00 PM
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 7 2022, 2:30 PM
gerritbot added a comment.Jan 7 2022, 2:52 PM

Change 751515 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Add an image: save the article without showing the save dialog on desktop

https://gerrit.wikimedia.org/r/751515

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 3:10 PM
Etonkovidova closed this task as Resolved.Jan 11 2022, 11:17 PM

Checked on betalabs - the issue is fixed.

Urbanecm_WMF added a project: GrowthExperiments-NewcomerTasks.Wed, Jan 21, 2:37 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits