Page MenuHomePhabricator

Fix mismatching field type of querycache_info.qci_timestamp on wmf wikis
Closed, ResolvedPublic

Description

https://drift-tracker.toolforge.org/report/core/ shows a schema drift for:

Mismatching field type of querycache_info.qci_timestamp

on s1, s2, s3, s4, s7

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.
The column was added in 2cda98321d7f03d4d17a545aef9e2e6599ada42f#change-pVGjpnYAcwz0

There is no ready ALTER statement in the commit history.

ALTER TABLE /*_*/querycache_info
  CHANGE qci_timestamp qci_timestamp BINARY(14) DEFAULT '19700101000000' NOT NULL;
  1. ALTERs to run: see above
  2. Where to run those changes: s1, s2, s3, s4, s7 - list of wikis needs to be created
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Progress

  • s1
  • s2
  • s3
  • s4
  • s7

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Mentioned in SAL (#wikimedia-operations) [2022-01-31T06:12:19Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1123 (T298559)', diff saved to https://phabricator.wikimedia.org/P19573 and previous config saved to /var/cache/conftool/dbconfig/20220131-061219-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T06:57:33Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1123 (T298559)', diff saved to https://phabricator.wikimedia.org/P19580 and previous config saved to /var/cache/conftool/dbconfig/20220131-065733-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T07:13:51Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1112 (T298559)', diff saved to https://phabricator.wikimedia.org/P19583 and previous config saved to /var/cache/conftool/dbconfig/20220131-071350-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T07:22:50Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1112 (T298559)', diff saved to https://phabricator.wikimedia.org/P19586 and previous config saved to /var/cache/conftool/dbconfig/20220131-072249-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T08:08:04Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1112 (T298559)', diff saved to https://phabricator.wikimedia.org/P19589 and previous config saved to /var/cache/conftool/dbconfig/20220131-080803-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T08:25:34Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1166 (T298559)', diff saved to https://phabricator.wikimedia.org/P19590 and previous config saved to /var/cache/conftool/dbconfig/20220131-082534-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T08:34:32Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1166 (T298559)', diff saved to https://phabricator.wikimedia.org/P19591 and previous config saved to /var/cache/conftool/dbconfig/20220131-083432-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T09:19:53Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1166 (T298559)', diff saved to https://phabricator.wikimedia.org/P19598 and previous config saved to /var/cache/conftool/dbconfig/20220131-091952-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T09:20:02Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1179 (T298559)', diff saved to https://phabricator.wikimedia.org/P19599 and previous config saved to /var/cache/conftool/dbconfig/20220131-091959-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T09:29:17Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1179 (T298559)', diff saved to https://phabricator.wikimedia.org/P19600 and previous config saved to /var/cache/conftool/dbconfig/20220131-092917-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:14:32Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1179 (T298559)', diff saved to https://phabricator.wikimedia.org/P19604 and previous config saved to /var/cache/conftool/dbconfig/20220131-101431-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:14:42Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1175 (T298559)', diff saved to https://phabricator.wikimedia.org/P19605 and previous config saved to /var/cache/conftool/dbconfig/20220131-101439-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T10:33:51Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1175 (T298559)', diff saved to https://phabricator.wikimedia.org/P19608 and previous config saved to /var/cache/conftool/dbconfig/20220131-103350-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T11:19:05Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1175 (T298559)', diff saved to https://phabricator.wikimedia.org/P19614 and previous config saved to /var/cache/conftool/dbconfig/20220131-111904-marostegui.json

s3 replicas done, going with the master now.

Mentioned in SAL (#wikimedia-operations) [2022-01-31T12:00:12Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1147 (T298559)', diff saved to https://phabricator.wikimedia.org/P19615 and previous config saved to /var/cache/conftool/dbconfig/20220131-120007-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T12:01:13Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1147 (T298559)', diff saved to https://phabricator.wikimedia.org/P19616 and previous config saved to /var/cache/conftool/dbconfig/20220131-120113-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T12:46:28Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1147 (T298559)', diff saved to https://phabricator.wikimedia.org/P19621 and previous config saved to /var/cache/conftool/dbconfig/20220131-124627-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T12:46:56Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1142 (T298559)', diff saved to https://phabricator.wikimedia.org/P19622 and previous config saved to /var/cache/conftool/dbconfig/20220131-124655-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T12:48:02Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1142 (T298559)', diff saved to https://phabricator.wikimedia.org/P19623 and previous config saved to /var/cache/conftool/dbconfig/20220131-124801-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T13:33:16Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1142 (T298559)', diff saved to https://phabricator.wikimedia.org/P19628 and previous config saved to /var/cache/conftool/dbconfig/20220131-133316-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T13:33:27Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1141 (T298559)', diff saved to https://phabricator.wikimedia.org/P19629 and previous config saved to /var/cache/conftool/dbconfig/20220131-133323-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T13:34:30Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1141 (T298559)', diff saved to https://phabricator.wikimedia.org/P19630 and previous config saved to /var/cache/conftool/dbconfig/20220131-133430-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T14:19:44Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1141 (T298559)', diff saved to https://phabricator.wikimedia.org/P19638 and previous config saved to /var/cache/conftool/dbconfig/20220131-141943-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T14:19:54Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1144:3314 (T298559)', diff saved to https://phabricator.wikimedia.org/P19639 and previous config saved to /var/cache/conftool/dbconfig/20220131-141951-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T14:20:58Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3314 (T298559)', diff saved to https://phabricator.wikimedia.org/P19640 and previous config saved to /var/cache/conftool/dbconfig/20220131-142057-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T15:06:12Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3314 (T298559)', diff saved to https://phabricator.wikimedia.org/P19649 and previous config saved to /var/cache/conftool/dbconfig/20220131-150611-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T15:06:23Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1143 (T298559)', diff saved to https://phabricator.wikimedia.org/P19650 and previous config saved to /var/cache/conftool/dbconfig/20220131-150619-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T15:07:25Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1143 (T298559)', diff saved to https://phabricator.wikimedia.org/P19651 and previous config saved to /var/cache/conftool/dbconfig/20220131-150725-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T15:52:39Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1143 (T298559)', diff saved to https://phabricator.wikimedia.org/P19659 and previous config saved to /var/cache/conftool/dbconfig/20220131-155239-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T15:52:50Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1146:3314 (T298559)', diff saved to https://phabricator.wikimedia.org/P19660 and previous config saved to /var/cache/conftool/dbconfig/20220131-155246-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T15:53:54Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1146:3314 (T298559)', diff saved to https://phabricator.wikimedia.org/P19661 and previous config saved to /var/cache/conftool/dbconfig/20220131-155353-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T16:39:09Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1146:3314 (T298559)', diff saved to https://phabricator.wikimedia.org/P19671 and previous config saved to /var/cache/conftool/dbconfig/20220131-163908-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T16:39:25Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1121 (T298559)', diff saved to https://phabricator.wikimedia.org/P19672 and previous config saved to /var/cache/conftool/dbconfig/20220131-163921-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T16:55:32Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1121 (T298559)', diff saved to https://phabricator.wikimedia.org/P19675 and previous config saved to /var/cache/conftool/dbconfig/20220131-165531-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T17:40:52Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1121 (T298559)', diff saved to https://phabricator.wikimedia.org/P19684 and previous config saved to /var/cache/conftool/dbconfig/20220131-174052-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T17:41:03Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1160 (T298559)', diff saved to https://phabricator.wikimedia.org/P19685 and previous config saved to /var/cache/conftool/dbconfig/20220131-174059-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T17:42:06Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1160 (T298559)', diff saved to https://phabricator.wikimedia.org/P19686 and previous config saved to /var/cache/conftool/dbconfig/20220131-174206-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T18:27:21Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1160 (T298559)', diff saved to https://phabricator.wikimedia.org/P19696 and previous config saved to /var/cache/conftool/dbconfig/20220131-182719-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T18:27:32Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1149 (T298559)', diff saved to https://phabricator.wikimedia.org/P19697 and previous config saved to /var/cache/conftool/dbconfig/20220131-182728-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T18:28:34Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1149 (T298559)', diff saved to https://phabricator.wikimedia.org/P19698 and previous config saved to /var/cache/conftool/dbconfig/20220131-182834-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T19:13:49Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1149 (T298559)', diff saved to https://phabricator.wikimedia.org/P19702 and previous config saved to /var/cache/conftool/dbconfig/20220131-191348-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T19:13:59Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Depooling db1148 (T298559)', diff saved to https://phabricator.wikimedia.org/P19703 and previous config saved to /var/cache/conftool/dbconfig/20220131-191356-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T19:26:05Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1148 (T298559)', diff saved to https://phabricator.wikimedia.org/P19704 and previous config saved to /var/cache/conftool/dbconfig/20220131-192604-marostegui.json

Mentioned in SAL (#wikimedia-operations) [2022-01-31T20:11:19Z] <marostegui@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1148 (T298559)', diff saved to https://phabricator.wikimedia.org/P19707 and previous config saved to /var/cache/conftool/dbconfig/20220131-201118-marostegui.json

Marostegui updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2022-04-27T16:04:13Z] <Amir1> foreachwikiindblist s6 mysql.php -- -e "desc querycache_info;" | grep -i qci_timestamp | grep -i varbinary | awk '{ print substr($1, 1, length($1)-1) }' | xargs -I {} sql {} --write -- -e 'ALTER TABLE /*_*/querycache_info CHANGE qci_timestamp qci_timestamp BINARY(14) DEFAULT '19700101000000' NOT NULL;' (T298559)

It was needed in s5 and s6, given that the table is extremely small and doesn't get much writes (once a day I think), I simply ran it on master with replication.