Page MenuHomePhabricator

Fix mismatching field type of revision.rev_timestamp on wmf wikis
Closed, ResolvedPublic

Description

https://drift-tracker.toolforge.org/report/core/ shows a schema drift for:

Mismatching field type of revision.rev_timestamp

on s1, s2, s3, s4, s7

According to T42626 the timestamp should be adjust from varbinary(14) to binary(14) because there is no need to hold infinite.
The column was added in 64ac6b8e775dd8582ea9cc5f24235488f076c5b3#change-pVGjpnYAcwz0

There is no ready ALTER statement in the commit history.

ALTER TABLE /*_*/revision
  CHANGE rev_timestamp rev_timestamp BINARY(14) NOT NULL;
  1. ALTERs to run: see above
  2. Where to run those changes: s1, s2, s3, s4, s7 - list of wikis needs to be created - Please check also s5, s6, s8 before closing as the drift tracker checks a random wiki, which could pass the check, while other wikis on the same section would fail the check
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Progress

  • s1: Done
  • s2: Done
  • s3: Done
  • s4: Done
  • s5: Done
  • s6: Done
  • s7: Done

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Mentioned in SAL (#wikimedia-operations) [2022-06-04T17:06:36Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1148 (T298560)', diff saved to https://phabricator.wikimedia.org/P29398 and previous config saved to /var/cache/conftool/dbconfig/20220604-170633-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T02:00:15Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1148 (T298560)', diff saved to https://phabricator.wikimedia.org/P29399 and previous config saved to /var/cache/conftool/dbconfig/20220605-020015-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T02:45:31Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1148 (T298560)', diff saved to https://phabricator.wikimedia.org/P29402 and previous config saved to /var/cache/conftool/dbconfig/20220605-024530-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T02:45:39Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1149 (T298560)', diff saved to https://phabricator.wikimedia.org/P29403 and previous config saved to /var/cache/conftool/dbconfig/20220605-024538-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T11:41:39Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1149 (T298560)', diff saved to https://phabricator.wikimedia.org/P29404 and previous config saved to /var/cache/conftool/dbconfig/20220605-114139-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T12:07:47Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T298560)', diff saved to https://phabricator.wikimedia.org/P29406 and previous config saved to /var/cache/conftool/dbconfig/20220605-120747-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T12:26:55Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1149 (T298560)', diff saved to https://phabricator.wikimedia.org/P29409 and previous config saved to /var/cache/conftool/dbconfig/20220605-122654-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T12:27:03Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1138 (T298560)', diff saved to https://phabricator.wikimedia.org/P29410 and previous config saved to /var/cache/conftool/dbconfig/20220605-122702-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T12:53:02Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1135 (T298560)', diff saved to https://phabricator.wikimedia.org/P29412 and previous config saved to /var/cache/conftool/dbconfig/20220605-125302-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T21:35:48Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1138 (T298560)', diff saved to https://phabricator.wikimedia.org/P29413 and previous config saved to /var/cache/conftool/dbconfig/20220605-213547-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T22:21:03Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1138 (T298560)', diff saved to https://phabricator.wikimedia.org/P29416 and previous config saved to /var/cache/conftool/dbconfig/20220605-222102-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-05T22:21:11Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1144:3314 (T298560)', diff saved to https://phabricator.wikimedia.org/P29417 and previous config saved to /var/cache/conftool/dbconfig/20220605-222110-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-06T08:31:54Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3314 (T298560)', diff saved to https://phabricator.wikimedia.org/P29432 and previous config saved to /var/cache/conftool/dbconfig/20220606-083153-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-06T09:17:09Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3314 (T298560)', diff saved to https://phabricator.wikimedia.org/P29435 and previous config saved to /var/cache/conftool/dbconfig/20220606-091709-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-06T18:11:03Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1143 (T298560)', diff saved to https://phabricator.wikimedia.org/P29442 and previous config saved to /var/cache/conftool/dbconfig/20220606-181103-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-07T03:32:06Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1143 (T298560)', diff saved to https://phabricator.wikimedia.org/P29444 and previous config saved to /var/cache/conftool/dbconfig/20220607-033206-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-07T04:17:21Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1143 (T298560)', diff saved to https://phabricator.wikimedia.org/P29447 and previous config saved to /var/cache/conftool/dbconfig/20220607-041721-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-09T09:24:15Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1106 (T298560)', diff saved to https://phabricator.wikimedia.org/P29586 and previous config saved to /var/cache/conftool/dbconfig/20220609-092413-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-10T05:46:04Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T298560)', diff saved to https://phabricator.wikimedia.org/P29608 and previous config saved to /var/cache/conftool/dbconfig/20220610-054603-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-10T06:31:19Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1106 (T298560)', diff saved to https://phabricator.wikimedia.org/P29611 and previous config saved to /var/cache/conftool/dbconfig/20220610-063119-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-10T06:31:30Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1119 (T298560)', diff saved to https://phabricator.wikimedia.org/P29612 and previous config saved to /var/cache/conftool/dbconfig/20220610-063127-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-11T02:51:59Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T298560)', diff saved to https://phabricator.wikimedia.org/P29617 and previous config saved to /var/cache/conftool/dbconfig/20220611-025158-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-11T03:37:14Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1119 (T298560)', diff saved to https://phabricator.wikimedia.org/P29620 and previous config saved to /var/cache/conftool/dbconfig/20220611-033713-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-11T03:37:23Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1099:3311 (T298560)', diff saved to https://phabricator.wikimedia.org/P29621 and previous config saved to /var/cache/conftool/dbconfig/20220611-033721-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-12T06:01:25Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T298560)', diff saved to https://phabricator.wikimedia.org/P29625 and previous config saved to /var/cache/conftool/dbconfig/20220612-060125-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-12T06:46:41Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1099:3311 (T298560)', diff saved to https://phabricator.wikimedia.org/P29628 and previous config saved to /var/cache/conftool/dbconfig/20220612-064640-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-13T02:15:11Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1105:3311 (T298560)', diff saved to https://phabricator.wikimedia.org/P29629 and previous config saved to /var/cache/conftool/dbconfig/20220613-021511-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-14T01:55:32Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T298560)', diff saved to https://phabricator.wikimedia.org/P29702 and previous config saved to /var/cache/conftool/dbconfig/20220614-015532-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-14T02:40:48Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1105:3311 (T298560)', diff saved to https://phabricator.wikimedia.org/P29705 and previous config saved to /var/cache/conftool/dbconfig/20220614-024047-ladsgroup.json

Doing it on the old s6 master (db1173)

Doing it on the old s6 master (db1173)

Done

Mentioned in SAL (#wikimedia-operations) [2022-06-28T20:52:07Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1169 (T298560)', diff saved to https://phabricator.wikimedia.org/P30590 and previous config saved to /var/cache/conftool/dbconfig/20220628-205206-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T20:52:21Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1132 (T298560)', diff saved to https://phabricator.wikimedia.org/P30591 and previous config saved to /var/cache/conftool/dbconfig/20220628-205220-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T21:37:36Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1132 (T298560)', diff saved to https://phabricator.wikimedia.org/P30595 and previous config saved to /var/cache/conftool/dbconfig/20220628-213735-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-28T21:38:10Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1184 (T298560)', diff saved to https://phabricator.wikimedia.org/P30596 and previous config saved to /var/cache/conftool/dbconfig/20220628-213806-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-29T16:36:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T298560)', diff saved to https://phabricator.wikimedia.org/P30624 and previous config saved to /var/cache/conftool/dbconfig/20220629-163612-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-06-29T17:21:28Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1184 (T298560)', diff saved to https://phabricator.wikimedia.org/P30627 and previous config saved to /var/cache/conftool/dbconfig/20220629-172127-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-08-16T06:23:50Z] <ladsgroup@cumin1001> START - Cookbook sre.hosts.downtime for 1 day, 0:00:00 on db1163.eqiad.wmnet with reason: Maint work on old s1 master (T312984 T312863 T310011 T309311 T60674 T298560 T298555 T310485 T301312)

Mentioned in SAL (#wikimedia-operations) [2022-08-16T06:24:04Z] <ladsgroup@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1 day, 0:00:00 on db1163.eqiad.wmnet with reason: Maint work on old s1 master (T312984 T312863 T310011 T309311 T60674 T298560 T298555 T310485 T301312)

Ladsgroup updated the task description. (Show Details)