Page MenuHomePhabricator

Fix mismatching field type of column text.old_flags on wmf wikis
Closed, ResolvedPublic

Description

https://drift-tracker.toolforge.org/report/core/ shows a schema drift for:

Mismatching field type of text.old_flags

on s3, s7

The field is a tinyblob since addition 64ac6b8e775dd8582ea9cc5f24235488f076c5b3

But wmf production is using varbinary on some sections:

root@db1112.eqiad.wmnet[thwikiquote]> show create table text\G
*************************** 1. row ***************************
       Table: text
Create Table: CREATE TABLE `text` (
  `old_id` int(8) unsigned NOT NULL AUTO_INCREMENT,
  `old_text` mediumblob NOT NULL,
  `old_flags` varbinary(255) NOT NULL,
  PRIMARY KEY (`old_id`)
) ENGINE=InnoDB AUTO_INCREMENT=42791 DEFAULT CHARSET=binary PACK_KEYS=1
1 row in set (0.001 sec)

Maybe the varbinary(255) is a better datatype from the production view?
A new task is should be used to request a code change and later adjust the other sections for the newest schema with this task

There is no ready ALTER statement in the commit history.

ALTER TABLE /*_*/text
  CHANGE old_flags old_flags TINYBLOB NOT NULL;
  1. ALTERs to run: see above
  2. Where to run those changes: s3, s7 - list of wikis needs to be created
  3. When to run those changes: any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: beta cluster is running with the new schema
  6. if the data should be made available on the labs replicas and/or dumps: no change of the existing rules

Progress

  • s1 (not needed)
  • s2 (not needed)
  • s3
  • s4 (not needed)
  • s5
  • s6
  • s7
  • s8 (not needed)

Related Objects

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
Marostegui updated the task description. (Show Details)

Old s7 master (db1136) done

Mentioned in SAL (#wikimedia-operations) [2022-04-21T03:25:59Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1158 (T298563)', diff saved to https://phabricator.wikimedia.org/P25854 and previous config saved to /var/cache/conftool/dbconfig/20220421-032556-ladsgroup.json

Please check also the other sections as the drift tracker checks a random wiki, which could pass the check, while other wikis on the same section would fail the check

The last run reports as well:
s5 db1161 cebwiki
s6 db1173 ruwiki

Mentioned in SAL (#wikimedia-operations) [2022-04-27T17:22:15Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1113:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26727 and previous config saved to /var/cache/conftool/dbconfig/20220427-172211-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T17:37:10Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26730 and previous config saved to /var/cache/conftool/dbconfig/20220427-173709-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T18:22:59Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26742 and previous config saved to /var/cache/conftool/dbconfig/20220427-182230-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T18:23:13Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1144:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26743 and previous config saved to /var/cache/conftool/dbconfig/20220427-182238-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T18:36:45Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26744 and previous config saved to /var/cache/conftool/dbconfig/20220427-183645-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T19:22:00Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1144:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26754 and previous config saved to /var/cache/conftool/dbconfig/20220427-192200-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T19:22:14Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1110 (T298563)', diff saved to https://phabricator.wikimedia.org/P26755 and previous config saved to /var/cache/conftool/dbconfig/20220427-192209-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T19:37:19Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298563)', diff saved to https://phabricator.wikimedia.org/P26759 and previous config saved to /var/cache/conftool/dbconfig/20220427-193719-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T20:22:35Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1110 (T298563)', diff saved to https://phabricator.wikimedia.org/P26772 and previous config saved to /var/cache/conftool/dbconfig/20220427-202234-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T21:00:44Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1130 (T298563)', diff saved to https://phabricator.wikimedia.org/P26785 and previous config saved to /var/cache/conftool/dbconfig/20220427-210041-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T21:13:53Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1130 (T298563)', diff saved to https://phabricator.wikimedia.org/P26791 and previous config saved to /var/cache/conftool/dbconfig/20220427-211352-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T21:59:16Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26805 and previous config saved to /var/cache/conftool/dbconfig/20220427-215914-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T22:16:01Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26809 and previous config saved to /var/cache/conftool/dbconfig/20220427-221600-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T23:01:17Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3315 (T298563)', diff saved to https://phabricator.wikimedia.org/P26826 and previous config saved to /var/cache/conftool/dbconfig/20220427-230116-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T23:01:40Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1161 (T298563)', diff saved to https://phabricator.wikimedia.org/P26827 and previous config saved to /var/cache/conftool/dbconfig/20220427-230130-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T23:14:38Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298563)', diff saved to https://phabricator.wikimedia.org/P26832 and previous config saved to /var/cache/conftool/dbconfig/20220427-231437-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-04-27T23:59:53Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1161 (T298563)', diff saved to https://phabricator.wikimedia.org/P26846 and previous config saved to /var/cache/conftool/dbconfig/20220427-235953-ladsgroup.json

Ladsgroup updated the task description. (Show Details)

Mentioned in SAL (#wikimedia-operations) [2022-05-02T00:01:51Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1113:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27196 and previous config saved to /var/cache/conftool/dbconfig/20220502-000151-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T00:51:19Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27202 and previous config saved to /var/cache/conftool/dbconfig/20220502-005118-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T01:36:34Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1113:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27211 and previous config saved to /var/cache/conftool/dbconfig/20220502-013633-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T01:36:42Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1098:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27212 and previous config saved to /var/cache/conftool/dbconfig/20220502-013641-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T02:34:30Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27216 and previous config saved to /var/cache/conftool/dbconfig/20220502-023429-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T03:19:45Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1098:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27226 and previous config saved to /var/cache/conftool/dbconfig/20220502-031944-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T05:40:41Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1096:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27264 and previous config saved to /var/cache/conftool/dbconfig/20220502-054040-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T06:37:40Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27281 and previous config saved to /var/cache/conftool/dbconfig/20220502-063740-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T07:22:56Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1096:3316 (T298563)', diff saved to https://phabricator.wikimedia.org/P27297 and previous config saved to /var/cache/conftool/dbconfig/20220502-072255-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T07:23:04Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1131 (T298563)', diff saved to https://phabricator.wikimedia.org/P27298 and previous config saved to /var/cache/conftool/dbconfig/20220502-072303-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T07:49:28Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1131 (T298563)', diff saved to https://phabricator.wikimedia.org/P27305 and previous config saved to /var/cache/conftool/dbconfig/20220502-074927-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T08:34:43Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1131 (T298563)', diff saved to https://phabricator.wikimedia.org/P27318 and previous config saved to /var/cache/conftool/dbconfig/20220502-083442-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T08:34:56Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1165 (T298563)', diff saved to https://phabricator.wikimedia.org/P27319 and previous config saved to /var/cache/conftool/dbconfig/20220502-083456-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T09:04:15Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298563)', diff saved to https://phabricator.wikimedia.org/P27324 and previous config saved to /var/cache/conftool/dbconfig/20220502-090415-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T09:49:31Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1165 (T298563)', diff saved to https://phabricator.wikimedia.org/P27332 and previous config saved to /var/cache/conftool/dbconfig/20220502-094930-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T09:49:40Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1180 (T298563)', diff saved to https://phabricator.wikimedia.org/P27333 and previous config saved to /var/cache/conftool/dbconfig/20220502-094938-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T10:15:19Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298563)', diff saved to https://phabricator.wikimedia.org/P27338 and previous config saved to /var/cache/conftool/dbconfig/20220502-101518-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T11:00:34Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1180 (T298563)', diff saved to https://phabricator.wikimedia.org/P27343 and previous config saved to /var/cache/conftool/dbconfig/20220502-110033-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T11:00:45Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Depooling db1168 (T298563)', diff saved to https://phabricator.wikimedia.org/P27344 and previous config saved to /var/cache/conftool/dbconfig/20220502-110041-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T11:25:03Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298563)', diff saved to https://phabricator.wikimedia.org/P27345 and previous config saved to /var/cache/conftool/dbconfig/20220502-112502-ladsgroup.json

Mentioned in SAL (#wikimedia-operations) [2022-05-02T12:10:18Z] <ladsgroup@cumin1001> dbctl commit (dc=all): 'Repooling after maintenance db1168 (T298563)', diff saved to https://phabricator.wikimedia.org/P27349 and previous config saved to /var/cache/conftool/dbconfig/20220502-121018-ladsgroup.json

Marostegui updated the task description. (Show Details)