Page MenuHomePhabricator

Grouped references not always displaying correctly in the visual diff
Closed, ResolvedPublic

Description

Reported by User:Wint7 at https://www.mediawiki.org/wiki/Topic:Wndo38unb28w8895

This involves an edit that adds a new <ref group="Something"> ref tag. The preview is correct/as expected, but the visual diff displays the ref an extra time at the end of the page.

Example diff:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:ESanders_(WMF)/sandbox/refgroup&diff=535022&oldid=535021&diffmode=visual&visualdiff

Event Timeline

Change 755738 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] DiffElement: Handle diffs where ref list groups are inserted

https://gerrit.wikimedia.org/r/755738

Change 755738 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] DiffElement: Handle diffs where ref list groups are inserted/removed

https://gerrit.wikimedia.org/r/755738

Change 755825 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1cf051b44)

https://gerrit.wikimedia.org/r/755825

Change 755825 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (1cf051b44)

https://gerrit.wikimedia.org/r/755825

matmarex moved this task from To Triage to Triaged on the VisualEditor board.
matmarex moved this task from Incoming to QA on the Editing-team (FY2021-22 Kanban Board) board.
matmarex added a project: Editing QA.
matmarex moved this task from Inbox to Low Priority on the Editing QA board.

Change 757486 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] Fix internal list diff when lists are fully inserted/removed

https://gerrit.wikimedia.org/r/757486

The first fix regressed with the list diff fixes, but are fixed again with the above patch.

Change 757486 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Fix internal list diff when lists are fully inserted/removed

https://gerrit.wikimedia.org/r/757486

Change 757507 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbeac08b7)

https://gerrit.wikimedia.org/r/757507

Change 757507 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (bbeac08b7)

https://gerrit.wikimedia.org/r/757507

ppelberg claimed this task.