Page MenuHomePhabricator

All pagers should have a shared ResourceLoader module
Closed, ResolvedPublic

Description

Currently the TablePager adds the ResourceLoaderModule mediawiki.pager.tablePager. This means any page using the TablePager class can be styled uniquely for a skin via skin styles

However other Pager classes e.g. HistoryPager do not have this module meaning they cannot be customized.

Acceptance criteria

  • A shared style module will be added via the base IndexPager class called mediawiki.pager.styles
  • Update CheckUser extension to use mediawiki.pager.styles instead of mediawiki.pager.tablePager

Event Timeline

Jdlrobson created this task.

Change 751773 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Deprecate `mediawiki.pager.tablePager` module for more generic module

https://gerrit.wikimedia.org/r/751773

Jdlrobson lowered the priority of this task from High to Medium.Jan 7 2022, 4:38 PM

Change 751773 merged by jenkins-bot:

[mediawiki/core@master] Deprecate `mediawiki.pager.tablePager` module for more generic module

https://gerrit.wikimedia.org/r/751773

Change 752191 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/CheckUser@master] Module mediawiki.pager.tablePager was renamed to mediawiki.pager.styles

https://gerrit.wikimedia.org/r/752191

Change 752192 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/PageAssessments@master] Module mediawiki.pager.tablePager was renamed to mediawiki.pager.styles

https://gerrit.wikimedia.org/r/752192

Change 752191 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Module mediawiki.pager.tablePager was renamed to mediawiki.pager.styles

https://gerrit.wikimedia.org/r/752191

Change 752786 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/core@master] Styles should be added to all IndexPagers

https://gerrit.wikimedia.org/r/752786

Change 752786 merged by jenkins-bot:

[mediawiki/core@master] Styles should be added to all IndexPagers

https://gerrit.wikimedia.org/r/752786

Jdlrobson claimed this task.