Page MenuHomePhabricator

Beta features checkboxes are enabled even with local exception off
Closed, DuplicatePublicBUG REPORT

Description

What is the problem?

On the "Beta features" tab of Special:Preferences, if any of the options are set globally their checkboxes can be checked even without turning on the local exception.

However, if you attempt to enable these beta features without checking the local exception, nothing will be saved to the database.

There are two exceptions:

  1. Structured Discussions on user talk (beta-feature-flow-user-talk-page), which will be saved to the database with the value of 0. However, it appears as if that option is always saved to the database when you submit the Special:Preferences form, regardless of whether it is global and whether it has its local exception checked.
  2. Automatically enable most beta features (betafeatures-auto-enroll) does get saved to the database with a value of 1, even if its local exception is unchecked and 0 in the database.

All the beta features I tested (but see note below) are saved correctly when the local exception is checked.

Note Different wikis have different beta features which the user can set. I have not tested setting the options for all available beta features on all the different wikis.

Also note that there is a dependency between the Automatically enable most beta features checkbox and all the other checkboxes. Checking it will disable some of the checkboxes below. This will make fixing and testing this bug trickier.

Steps to reproduce problem
  1. Go to Special:GlobalPreferences (e.g. https://en.wikipedia.beta.wmflabs.org/wiki/Special:GlobalPreferences)
  2. Go to the "Beta features" tab and make some or all of the beta features global
  3. Go to Special:Preferences and go to the "Beta features" tab

Expected behavior: The checkboxes of the beta features you made global in step 2 are disabled.
Observed behavior: The checkboxes are enabled and can be checked/unchecked.

Environment

Browser: Firefox 78, Chromium 87
Wiki(s):https://test.wikipedia.org and https://en.wikipedia.beta.wmflabs.org GlobalPreferences 0.1.2 (c91eb42) 15:24, 9 December 2021.

Screenshots

beta_features.png (681×742 px, 58 KB)

It is also true for the "auto-enroll" feature:
beta_features_autoenroll.png (278×678 px, 33 KB)