nova wmfsink not deleting dns records for proxies whose name equals to project name
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	taavi
	Jan 6 2022, 11:09 AM

Description

wmfsink is the component responsible for cleaning up after deleted Nova instances. One step of the cleanup is deleting web proxies pointing at the deleted instance, also deleting the DNS record for the proxy. This DNS record cleanup fails in cases where the proxy name is the apex record of a designate zone (for example, when the proxy name equals to the project name). I assume we need to adjust the following zone detection code:

# operations/puppet modules/openstack/files/victoria/designate/wmf_sink/base.py
parentzone = '.'.join(proxyzone.split('.')[1:])

to account for this case.

related: T295246

Details

	Subject	Repo	Branch	Lines +/-
	wmf_sink base: fix the calculation of proxy parent zone	operations/puppet	production	+4 -1
	designate sink: fix proxy cleanup when proxy domain == project domain	operations/puppet	production	+6 -4

Customize query in gerrit

Related Objects

Mentioned Here: T295246: Dynamicproxy API should be useful without the Horizon dashboard

Event Timeline

taavi created this task.Jan 6 2022, 11:09 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2022, 11:09 AM

RhinosF1 subscribed.Jan 6 2022, 1:09 PM

parentzone = '.'.join(proxyzone.split('.')[:3]) ?

That's not the complete solution since these proxies are a special case in every way... but it's a start.

Change 751963 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[operations/puppet@production] designate sink: fix proxy cleanup when proxy domain == project domain

https://gerrit.wikimedia.org/r/751963

gerritbot added a project: Patch-For-Review.Jan 6 2022, 4:32 PM

In T298681#7601795, @Andrew wrote:

parentzone = '.'.join(proxyzone.split('.')[:3]) ?

After chasing down more edge cases I have settled on

'.'.join(proxyzone.split('.')[proxyzone.split('.').index(project):])

Change 751963 merged by Andrew Bogott:

[operations/puppet@production] designate sink: fix proxy cleanup when proxy domain == project domain

https://gerrit.wikimedia.org/r/751963

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 5:10 PM

Change 752181 had a related patch set uploaded (by Andrew Bogott; author: Andrew Bogott):

[operations/puppet@production] wmf_sink base: fix the calculation of proxy parent zone

https://gerrit.wikimedia.org/r/752181

gerritbot added a project: Patch-For-Review.Jan 7 2022, 5:58 PM

Change 752181 merged by Andrew Bogott:

[operations/puppet@production] wmf_sink base: fix the calculation of proxy parent zone

https://gerrit.wikimedia.org/r/752181

Andrew closed this task as Resolved.Jan 7 2022, 6:05 PM

Andrew claimed this task.

Maintenance_bot removed a project: Patch-For-Review.Jan 7 2022, 6:10 PM

nova wmfsink not deleting dns records for proxies whose name equals to project nameClosed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

nova wmfsink not deleting dns records for proxies whose name equals to project name
Closed, ResolvedPublic
Actions