Page MenuHomePhabricator
Create Task
Maniphest T298687

Query caller comments /* Class::method */ not available in slow queries logstash dashboard
Closed, ResolvedPublic
Actions

Description

The new slow queries dashboard, replacing a part of Tendril, currently doesn’t show the usual /* Class::method */ comments indicating the caller of a query. This makes the overview of top slow queries less useful: unless you recognize the query, you need to go to an event for this message and look at its exception.* fields (especially exception.trace) to figure out where the query is coming from.

Details

SubjectRepoBranchLines +/-
rdbms: Pass commented SQL to the GeneralizedSql for loggingmediawiki/corewmf/1.38.0-wmf.19+1 -1
rdbms: Pass commented SQL to the GeneralizedSql for loggingmediawiki/coremaster+1 -1
rdbms: Pass commented SQL to GeneralizedSql alongside the raw onemediawiki/coremaster+7 -3
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Jan 6 2022, 12:30 PM
Restricted Application added projects: Performance-Team, Platform Engineering. · View Herald TranscriptJan 6 2022, 12:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Krinkle renamed this task from Query caller comments /* Class::method() */ not available in slow queries logstash dashboard to Query caller comments /* Class::method */ not available in slow queries logstash dashboard.Jan 6 2022, 2:59 PM
Krinkle updated the task description. (Show Details)
Krinkle removed projects: Platform Engineering, Wikimedia-Logstash.
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
Krinkle added a project: DBA.
Krinkle added subscribers: Ladsgroup, Krinkle.

\cc @Ladsgroup.

Krinkle triaged this task as Medium priority.Jan 6 2022, 3:00 PM
Krinkle added a project: Developer Productivity.
Ladsgroup added a comment.Jan 7 2022, 3:49 AM

Yeah, It's not that important given that it's still accessible via stacktrace but I will get to it to make it appear in fullQuery field.

• Marostegui assigned this task to Ladsgroup.Jan 7 2022, 6:11 AM
• Marostegui moved this task from Triage to In progress on the DBA board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 7 2022, 6:11 AM
LSobanski subscribed.Jan 10 2022, 12:01 PM
• kchapman moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.Jan 10 2022, 7:50 PM
gerritbot added a comment.Jan 25 2022, 6:17 PM

Change 757051 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Pass commented SQL to the GeneralizedSql for logging

https://gerrit.wikimedia.org/r/757051

gerritbot added a project: Patch-For-Review.Jan 25 2022, 6:17 PM
gerritbot added a comment.Jan 25 2022, 6:22 PM

Change 757052 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] rdbms: Pass commented SQL to GeneralizedSql alongside the raw one

https://gerrit.wikimedia.org/r/757052

Ladsgroup added a comment.Jan 25 2022, 6:38 PM

One of those two patches should be merged, I don't care which tbh.

gerritbot added a comment.Jan 26 2022, 10:16 AM

Change 757052 abandoned by Ladsgroup:

[mediawiki/core@master] rdbms: Pass commented SQL to GeneralizedSql alongside the raw one

Reason:

We are going to the alternative approach

https://gerrit.wikimedia.org/r/757052

gerritbot added a comment.Jan 26 2022, 10:31 AM

Change 757051 merged by jenkins-bot:

[mediawiki/core@master] rdbms: Pass commented SQL to the GeneralizedSql for logging

https://gerrit.wikimedia.org/r/757051

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 26 2022, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 11:11 AM
gerritbot added a comment.Jan 26 2022, 11:23 AM

Change 757133 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@wmf/1.38.0-wmf.19] rdbms: Pass commented SQL to the GeneralizedSql for logging

https://gerrit.wikimedia.org/r/757133

gerritbot added a project: Patch-For-Review.Jan 26 2022, 11:23 AM
gerritbot added a comment.Jan 26 2022, 11:39 AM

Change 757133 merged by jenkins-bot:

[mediawiki/core@wmf/1.38.0-wmf.19] rdbms: Pass commented SQL to the GeneralizedSql for logging

https://gerrit.wikimedia.org/r/757133

Stashbot added a comment.Jan 26 2022, 11:41 AM

Mentioned in SAL (#wikimedia-operations) [2022-01-26T11:41:29Z] <ladsgroup@deploy1002> Synchronized php-1.38.0-wmf.19/includes/libs/rdbms/database/Database.php: Backport: [[gerrit:757133|rdbms: Pass commented SQL to the GeneralizedSql for logging (T298687)]] (duration: 00m 54s)

Ladsgroup closed this task as Resolved.Jan 26 2022, 11:41 AM
Ladsgroup moved this task from Incoming to Done on the User-Ladsgroup board.

This is not deployed to all wikis yet but it will be there by end of the week (hopefully)

ReleaseTaggerBot edited projects, added MW-1.38-notes (1.38.0-wmf.19; 2022-01-24); removed MW-1.38-notes (1.38.0-wmf.20; 2022-01-31).Jan 26 2022, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 26 2022, 12:11 PM
gerritbot added a comment.Feb 8 2022, 7:41 PM

Change 761041 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[mediawiki/services/function-schemata@master] Add definitions for Trigger Metadata builtin function.

https://gerrit.wikimedia.org/r/761041

gerritbot added a project: Patch-For-Review.Feb 8 2022, 7:41 PM
Jdforrester-WMF removed a project: Patch-For-Review.Feb 8 2022, 8:04 PM
Jdforrester-WMF subscribed.

Typo, sorry!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL