Page MenuHomePhabricator

Change old_text in Postgres to BYTEA
Open, Needs TriagePublic

Description

Event Timeline

Umherirrender subscribed.

There is one skipped postgres test with two provides related to this

00:16:35 There was 1 error:
00:16:35 
00:16:35 1) MediaWiki\Tests\Storage\SqlBlobStoreTest::testSimpleStoreGetBlobSimpleRoundtripWindowsLegacyEncodingGzip with data set #1 ('someText')
00:16:35 gzinflate(): data error
00:16:35 
00:16:35 /workspace/src/includes/Storage/SqlBlobStore.php:592
00:16:35 /workspace/src/includes/Storage/SqlBlobStore.php:522
00:16:35 /workspace/src/includes/Storage/SqlBlobStore.php:431
00:16:35 /workspace/src/includes/Storage/SqlBlobStore.php:282
00:16:35 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1689
00:16:35 /workspace/src/includes/libs/objectcache/wancache/WANObjectCache.php:1518
00:16:35 /workspace/src/includes/Storage/SqlBlobStore.php:287
00:16:35 /workspace/src/tests/phpunit/includes/Storage/SqlBlobStoreTest.php:432
00:16:35 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:452
00:16:35 === Logs generated by test case
00:16:35 [objectcache] [debug] MainWANObjectCache using store {class} {"class":"EmptyBagOStuff"}
00:16:35 ===

00:16:35 There were failures:
00:16:35 14) MediaWiki\Tests\Storage\SqlBlobStoreTest::testSimpleStoreGetBlobSimpleRoundtripWindowsLegacyEncodingGzip with data set #2 ('söme\ntäxt')
00:16:35 Failed asserting that two strings are identical.
00:16:35 --- Expected
00:16:35 +++ Actual
00:16:35 @@ @@
00:16:35 -'söme
00:16:35 -täxt'
00:16:35 +'sϖmooooY'